Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2387063003: [MD Settings][People] sync icon instead of checkmark to represent successful sync (Closed)

Created:
4 years, 2 months ago by Moe
Modified:
4 years, 2 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Settings][People] sync icon instead of checkmark to represent successful sync BUG=638467 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c2897611468f3615ff9297281c9b88f8a9852861 Cr-Commit-Position: refs/heads/master@{#422557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
Moe
Hi tommy, Please review this CL.
4 years, 2 months ago (2016-10-03 19:37:00 UTC) #4
tommycli
lgtm. Thanks for taking care of this moe!
4 years, 2 months ago (2016-10-03 20:38:29 UTC) #9
Moe
On 2016/10/03 20:38:29, tommycli wrote: > lgtm. Thanks for taking care of this moe! not ...
4 years, 2 months ago (2016-10-03 22:01:57 UTC) #10
tommycli
On 2016/10/03 22:01:57, moe wrote: > On 2016/10/03 20:38:29, tommycli wrote: > > lgtm. Thanks ...
4 years, 2 months ago (2016-10-03 22:02:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387063003/1
4 years, 2 months ago (2016-10-03 22:03:15 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 22:10:34 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 22:14:34 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2897611468f3615ff9297281c9b88f8a9852861
Cr-Commit-Position: refs/heads/master@{#422557}

Powered by Google App Engine
This is Rietveld 408576698