Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.html

Issue 2387053004: [MD settings] tweaks to what is shown in about page; and css cleanup (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/about_page/about_page.html
diff --git a/chrome/browser/resources/settings/about_page/about_page.html b/chrome/browser/resources/settings/about_page/about_page.html
index 72380ebadf2b95bc2ef663ba41385ebaff2fe014..657f20668ac2d4822b0d9f29e377d680dcff9010 100644
--- a/chrome/browser/resources/settings/about_page/about_page.html
+++ b/chrome/browser/resources/settings/about_page/about_page.html
@@ -25,6 +25,10 @@
<dom-module id="settings-about-page">
<template>
<style include="settings-shared settings-page-styles">
+ :host {
+ --about-page-image-space: 10px; /* Only used on about page. */
Dan Beam 2016/10/04 00:06:58 i think the fact that it's in :host {} and named -
dschuyler 2016/10/04 18:33:07 Done.
+ }
+
.copyable {
-webkit-user-select: text;
}
@@ -36,11 +40,12 @@
}
img {
- -webkit-margin-end: 10px;
+ -webkit-margin-end: var(--about-page-image-space);
}
iron-icon {
- -webkit-margin-end: var(--iron-icon-spacing);
+ -webkit-margin-end: var(--about-page-image-space);
+ width: 32px; /* the width of the product-logo img. */
Dan Beam 2016/10/04 00:06:58 nit: capitalize The
dschuyler 2016/10/04 18:33:07 Done.
}
iron-icon[icon='settings:check-circle'] {
@@ -69,7 +74,7 @@
<settings-section page-title="$i18n{aboutPageTitle}" section="about">
<settings-animated-pages id="pages" section="about">
<neon-animatable route-path="default">
- <div class="settings-box">
+ <div class="settings-box two-line">
<img id="product-logo" on-tap="onProductLogoTap_"
srcset="chrome://theme/current-channel-logo@1x 1x,
chrome://theme/current-channel-logo@2x 2x" alt="">
@@ -104,15 +109,16 @@
</span>
<div class="secondary copyable">$i18n{aboutBrowserVersion}</div>
</div>
- <span class="secondary-action">
- <paper-button id="relaunch" class="secondary-button"
+ <span
<if expr="not chromeos">
- hidden="[[!shouldShowRelaunch_(currentUpdateStatusEvent_)]]"
+ hidden="[[!shouldShowRelaunch_(currentUpdateStatusEvent_)]]"
</if>
<if expr="chromeos">
- hidden="[[!shouldShowRelaunch_(
- currentUpdateStatusEvent_, targetChannel_)]]"
+ hidden="[[!shouldShowRelaunch_(
+ currentUpdateStatusEvent_, targetChannel_)]]"
</if>
+ class="secondary-action">
+ <paper-button id="relaunch" class="secondary-button"
on-tap="onRelaunchTap_">
$i18n{aboutRelaunch}
</paper-button>

Powered by Google App Engine
This is Rietveld 408576698