[MD settings] tweaks to what is shown in about page; and css cleanup

[MD settings] tweaks to what is shown in about page; and css cleanup

This CL hides the vertical grey bar (secondary action separator) in the
version row of the About page (when appropriate). It also adjusts the
spacing around the icon in that row to better match the mocks.

While doing the above I noticed there was an old reference to
--iron-icon-spacing which is obsolete so I removed references to that
as well.

BUG=651697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886
Cr-Commit-Position: refs/heads/master@{#423607}

[dschuyler, 2016-10-03 23:22:08]

Description was changed from

==========
[MD settings] tweaks to what is shown in about page; and css cleanup

This CL hides the vertical grey bar (secondary action separator) in the
version row of the About page (when appropriate). It also adjusts the
spacing around the icon in that row to match the mocks.

While doing the above I noticed there was an old reference to
--iron-icon-spacing which is obsolete so I removed references to that
as well.

BUG=651697
==========

to

==========
[MD settings] tweaks to what is shown in about page; and css cleanup

This CL hides the vertical grey bar (secondary action separator) in the
version row of the About page (when appropriate). It also adjusts the
spacing around the icon in that row to match the mocks.

While doing the above I noticed there was an old reference to
--iron-icon-spacing which is obsolete so I removed references to that
as well.

BUG=651697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-10-03 23:22:13]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 23:23:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-03 23:24:17]

Description was changed from

==========
[MD settings] tweaks to what is shown in about page; and css cleanup

This CL hides the vertical grey bar (secondary action separator) in the
version row of the About page (when appropriate). It also adjusts the
spacing around the icon in that row to match the mocks.

While doing the above I noticed there was an old reference to
--iron-icon-spacing which is obsolete so I removed references to that
as well.

BUG=651697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] tweaks to what is shown in about page; and css cleanup

This CL hides the vertical grey bar (secondary action separator) in the
version row of the About page (when appropriate). It also adjusts the
spacing around the icon in that row to better match the mocks.

While doing the above I noticed there was an old reference to
--iron-icon-spacing which is obsolete so I removed references to that
as well.

BUG=651697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-10-03 23:24:32]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-10-04 00:06:59]

lgtm

https://codereview.chromium.org/2387053004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2387053004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.html:29:
--about-page-image-space: 10px;  /* Only used on about page. */
i think the fact that it's in :host {} and named --about-page* is probably good
enough (no need for the comment, IMO)

https://codereview.chromium.org/2387053004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.html:48: width: 32px; 
/* the width of the product-logo img. */
nit: capitalize The

[commit-bot: I haz the power, 2016-10-04 00:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:27:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dschuyler, 2016-10-04 18:31:19]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 18:32:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-04 18:33:07]

fixed browser test

https://codereview.chromium.org/2387053004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2387053004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.html:29:
--about-page-image-space: 10px;  /* Only used on about page. */
On 2016/10/04 00:06:58, Dan Beam wrote:
> i think the fact that it's in :host {} and named --about-page* is probably
good
> enough (no need for the comment, IMO)

Done.

https://codereview.chromium.org/2387053004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.html:48: width: 32px; 
/* the width of the product-logo img. */
On 2016/10/04 00:06:58, Dan Beam wrote:
> nit: capitalize The

Done.

[commit-bot: I haz the power, 2016-10-04 19:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 19:13:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dschuyler, 2016-10-06 00:41:17]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 00:42:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 02:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 02:35:55]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-10-06 18:44:02]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-10-06 18:44:03]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2387053004/#ps40001
(title: "fixing chromeos browser tests")

[commit-bot: I haz the power, 2016-10-06 18:45:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:50:53]

Description was changed from

==========
[MD settings] tweaks to what is shown in about page; and css cleanup

This CL hides the vertical grey bar (secondary action separator) in the
version row of the About page (when appropriate). It also adjusts the
spacing around the icon in that row to better match the mocks.

While doing the above I noticed there was an old reference to
--iron-icon-spacing which is obsolete so I removed references to that
as well.

BUG=651697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] tweaks to what is shown in about page; and css cleanup

This CL hides the vertical grey bar (secondary action separator) in the
version row of the About page (when appropriate). It also adjusts the
spacing around the icon in that row to better match the mocks.

While doing the above I noticed there was an old reference to
--iron-icon-spacing which is obsolete so I removed references to that
as well.

BUG=651697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-06 18:50:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-06 18:52:40]

Description was changed from

==========
[MD settings] tweaks to what is shown in about page; and css cleanup

This CL hides the vertical grey bar (secondary action separator) in the
version row of the About page (when appropriate). It also adjusts the
spacing around the icon in that row to better match the mocks.

While doing the above I noticed there was an old reference to
--iron-icon-spacing which is obsolete so I removed references to that
as well.

BUG=651697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] tweaks to what is shown in about page; and css cleanup

This CL hides the vertical grey bar (secondary action separator) in the
version row of the About page (when appropriate). It also adjusts the
spacing around the icon in that row to better match the mocks.

While doing the above I noticed there was an old reference to
--iron-icon-spacing which is obsolete so I removed references to that
as well.

BUG=651697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886
Cr-Commit-Position: refs/heads/master@{#423607}
==========

[commit-bot: I haz the power, 2016-10-06 18:52:40]

Patchset 3 (id:??) landed as
https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886
Cr-Commit-Position: refs/heads/master@{#423607}