Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Issue 2387033002: remove obsolete(?) git attributes from old top-level WebKit settings (Closed)

Created:
4 years, 2 months ago by Mostyn Bramley-Moore
Modified:
4 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove obsolete(?) git attributes from old top-level WebKit settings It is a little surprising (for automated scripts, mostly) for files to be export-ignore'd from subdirectories. This patch removes some old WebKit export-ignore attributes that I suspect are no longer useful. This was the original patch that added the attributes, I have not been able to locate details of the review or why it was originally required: https://chromium.googlesource.com/chromium/src.git/+/20706fd0c00d214a264439277e0bc8e90ccba203 Committed: https://crrev.com/60f9e84ef2251fbf3492b7429cbb314f507be574 Cr-Commit-Position: refs/heads/master@{#422412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/.gitattributes View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Mostyn Bramley-Moore
@Nico: please take a look at this .gitattributes cleanup. (I'm not sure why this was ...
4 years, 2 months ago (2016-10-03 10:23:53 UTC) #4
Nico
lgtm
4 years, 2 months ago (2016-10-03 13:48:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387033002/1
4 years, 2 months ago (2016-10-03 14:06:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 14:11:45 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 14:14:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60f9e84ef2251fbf3492b7429cbb314f507be574
Cr-Commit-Position: refs/heads/master@{#422412}

Powered by Google App Engine
This is Rietveld 408576698