Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2387003003: [Downloads UI] Add null checks to prevent crash when selecting deleted items (Closed)

Created:
4 years, 2 months ago by Theresa
Modified:
4 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads UI] Add null checks to prevent crash when selecting deleted items If you move quickly enough, it's possible to select an item that was just deleted then choose to delete it again. Add some null checks to prevent a crash. BUG=652176 Committed: https://crrev.com/484d6ab408cd722254b9e80757558ae3948a1721 Cr-Commit-Position: refs/heads/master@{#422662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Theresa
ptal
4 years, 2 months ago (2016-10-03 22:54:17 UTC) #3
gone
lgtm
4 years, 2 months ago (2016-10-04 00:21:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387003003/1
4 years, 2 months ago (2016-10-04 00:30:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 01:54:34 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 01:56:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/484d6ab408cd722254b9e80757558ae3948a1721
Cr-Commit-Position: refs/heads/master@{#422662}

Powered by Google App Engine
This is Rietveld 408576698