Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2386993004: Revert of Make GrResourceCache dynamically change between LRU and random replacement strategies. (Closed)

Created:
4 years, 2 months ago by robertphillips
Modified:
4 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make GrResourceCache dynamically change between LRU and random replacement strategies. (patchset #8 id:140001 of https://codereview.chromium.org/2321563006/ ) Reason for revert: Causing problems on Mac & Windows bots. Original issue's description: > Make GrResourceCache dynamically change between LRU and random replacement strategies. > > Random performs significantly better when each frame exceeds the budget by a small margin whereas LRU has worst case behavior. > > The decision of which to use is made based on the history from a few frames of the ratio of total unique key cache misses to unique key cache misses of resources purged in the last 2 frames. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321563006 > > Committed: https://skia.googlesource.com/skia/+/0f147ac2ae575bbad3515a526f13700bc5c8e9d7 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/ee843b2ae4d75748d8bc323287f0c310fad548a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -174 lines) Patch
M include/gpu/GrGpuResource.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 2 chunks +2 lines, -12 lines 0 comments Download
M src/gpu/GrResourceCache.h View 8 chunks +16 lines, -54 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 11 chunks +20 lines, -104 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
robertphillips
Created Revert of Make GrResourceCache dynamically change between LRU and random replacement strategies.
4 years, 2 months ago (2016-10-04 12:30:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386993004/1
4 years, 2 months ago (2016-10-04 12:30:14 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 12:30:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ee843b2ae4d75748d8bc323287f0c310fad548a7

Powered by Google App Engine
This is Rietveld 408576698