content: Remove gpu memory buffer manager from ChildThreadImpl.

content: Remove gpu memory buffer manager from ChildThreadImpl.

Only RenderThreadImpl does anything with the gpu memory buffer manager.
So move it out of ChildThreadImpl into RenderThreadImpl.

This also ensures that if mus is used, then ChildGpuMemoryBufferManager
is not created and accidentally used. This fixes a crash in extensions
using the tab-capture api when running with --use-mus-in-renderer.

BUG=643746
Committed: https://crrev.com/b9ff6c9da80f39e37c8f44cd0f9d8749f0fa377f
Cr-Commit-Position: refs/heads/master@{#422675}

[sadrul, 2016-10-02 04:42:31]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 04:42:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 04:50:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-02 04:50:07]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[sadrul, 2016-10-02 05:14:54]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 05:15:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 05:57:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-02 05:57:41]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-10-02 16:35:47]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 16:35:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-10-02 16:36:25]

Description was changed from

==========
[wip] content: Remove gpu memory buffer manager from ChildThreadImpl.

Only RenderThreadImpl does anything with the gpu memory buffer manager.
So move it out of ChildThreadImpl into RenderThreadImpl.

This also ensures that if mus is used, then ChildGpuMemoryBufferManager
is not created and accidentally used. This fixes a crash when using an
extension that uses tab-capture in mus.

BUG=...
==========

to

==========
content: Remove gpu memory buffer manager from ChildThreadImpl.

Only RenderThreadImpl does anything with the gpu memory buffer manager.
So move it out of ChildThreadImpl into RenderThreadImpl.

This also ensures that if mus is used, then ChildGpuMemoryBufferManager
is not created and accidentally used. This fixes a crash when using an
extension that uses tab-capture in mus.

BUG=...
==========

[sadrul, 2016-10-02 16:38:03]

Description was changed from

==========
content: Remove gpu memory buffer manager from ChildThreadImpl.

Only RenderThreadImpl does anything with the gpu memory buffer manager.
So move it out of ChildThreadImpl into RenderThreadImpl.

This also ensures that if mus is used, then ChildGpuMemoryBufferManager
is not created and accidentally used. This fixes a crash when using an
extension that uses tab-capture in mus.

BUG=...
==========

to

==========
content: Remove gpu memory buffer manager from ChildThreadImpl.

Only RenderThreadImpl does anything with the gpu memory buffer manager.
So move it out of ChildThreadImpl into RenderThreadImpl.

This also ensures that if mus is used, then ChildGpuMemoryBufferManager
is not created and accidentally used. This fixes a crash in extensions
using the tab-capture api when running with --use-mus-in-renderer.

BUG=643746
==========

[sadrul, 2016-10-02 16:40:58]

sadrul@chromium.org changed reviewers:
+ creis@chromium.org, reveman@chromium.org

[sadrul, 2016-10-02 16:40:59]

reveman@ Please review moving the test from child_thread_impl_browsertest.cc to
render_thread_impl_browsertest.cc

creis@ for owner review.

[commit-bot: I haz the power, 2016-10-02 17:16:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-02 17:16:46]

Dry run: This issue passed the CQ dry run.

[reveman, 2016-10-03 15:37:41]

https://codereview.chromium.org/2386913002/diff/40001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2386913002/diff/40001/content/renderer/render...
content/renderer/render_thread_impl.cc:1642: gpu_memory_buffer_manager_ =
Can you initialize this in RenderThreadImpl::Init instead of doing it lazily?

https://codereview.chromium.org/2386913002/diff/40001/content/renderer/render...
File content/renderer/render_thread_impl_browsertest.cc (right):

https://codereview.chromium.org/2386913002/diff/40001/content/renderer/render...
content/renderer/render_thread_impl_browsertest.cc:281: class
ChildThreadImplGpuMemoryBufferBrowserTest
nit: RenderThreadImplGpuMemoryBufferBrowserTest

https://codereview.chromium.org/2386913002/diff/40001/content/renderer/render...
content/renderer/render_thread_impl_browsertest.cc:294: void
SetUpOnChildThread() {
nit: SetUpOnRenderThread

[sadrul, 2016-10-03 21:23:54]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2016-10-03 21:24:20]

https://codereview.chromium.org/2386913002/diff/40001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2386913002/diff/40001/content/renderer/render...
content/renderer/render_thread_impl.cc:1642: gpu_memory_buffer_manager_ =
On 2016/10/03 15:37:40, reveman wrote:
> Can you initialize this in RenderThreadImpl::Init instead of doing it lazily?

Done.

https://codereview.chromium.org/2386913002/diff/40001/content/renderer/render...
File content/renderer/render_thread_impl_browsertest.cc (right):

https://codereview.chromium.org/2386913002/diff/40001/content/renderer/render...
content/renderer/render_thread_impl_browsertest.cc:281: class
ChildThreadImplGpuMemoryBufferBrowserTest
On 2016/10/03 15:37:40, reveman wrote:
> nit: RenderThreadImplGpuMemoryBufferBrowserTest

Done.

https://codereview.chromium.org/2386913002/diff/40001/content/renderer/render...
content/renderer/render_thread_impl_browsertest.cc:294: void
SetUpOnChildThread() {
On 2016/10/03 15:37:41, reveman wrote:
> nit: SetUpOnRenderThread

Done.

[commit-bot: I haz the power, 2016-10-03 21:25:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2016-10-03 21:47:44]

lgtm with nits

https://codereview.chromium.org/2386913002/diff/60001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2386913002/diff/60001/content/renderer/render...
content/renderer/render_thread_impl.cc:660: if
(should_create_gpu_memory_buffer_manager) {
nit: I think the overhead of creating this instance is minimal so it's fine to
keep this simple a create it unconditionally

https://codereview.chromium.org/2386913002/diff/60001/content/renderer/render...
content/renderer/render_thread_impl.cc:1647: if (!gpu_memory_buffer_manager_) {
remove this?

[commit-bot: I haz the power, 2016-10-03 23:12:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 23:12:33]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-10-03 23:32:36]

content/ LGTM with nit.

https://codereview.chromium.org/2386913002/diff/60001/content/renderer/render...
File content/renderer/render_thread_impl_browsertest.cc (right):

https://codereview.chromium.org/2386913002/diff/60001/content/renderer/render...
content/renderer/render_thread_impl_browsertest.cc:326: DISABLED_Map) {
I see that this was disabled in its old location as well, but I don't see a bug
for enabling it.  Can you file one and put the number in a comment?  (Or am I
misunderstanding and the macro magic below somehow gets it to run?)

[sadrul, 2016-10-04 00:59:45]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 01:00:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-10-04 01:05:32]

https://codereview.chromium.org/2386913002/diff/60001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2386913002/diff/60001/content/renderer/render...
content/renderer/render_thread_impl.cc:660: if
(should_create_gpu_memory_buffer_manager) {
On 2016/10/03 21:47:44, reveman wrote:
> nit: I think the overhead of creating this instance is minimal so it's fine to
> keep this simple a create it unconditionally 

Done.

https://codereview.chromium.org/2386913002/diff/60001/content/renderer/render...
content/renderer/render_thread_impl.cc:1647: if (!gpu_memory_buffer_manager_) {
On 2016/10/03 21:47:44, reveman wrote:
> remove this?

Sorry, I was sloppy. Removed.

https://codereview.chromium.org/2386913002/diff/60001/content/renderer/render...
File content/renderer/render_thread_impl_browsertest.cc (right):

https://codereview.chromium.org/2386913002/diff/60001/content/renderer/render...
content/renderer/render_thread_impl_browsertest.cc:326: DISABLED_Map) {
On 2016/10/03 23:32:36, Charlie Reis wrote:
> I see that this was disabled in its old location as well, but I don't see a
bug
> for enabling it.  Can you file one and put the number in a comment?  (Or am I
> misunderstanding and the macro magic below somehow gets it to run?)

Nope, the tests are disabled. Filed a bug and referenced it from here.

[commit-bot: I haz the power, 2016-10-04 01:11:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 01:11:22]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2016-10-04 01:21:45]

Patchset #5 (id:80001) has been deleted

[sadrul, 2016-10-04 01:24:26]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 01:24:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-10-04 01:57:09]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-10-04 01:57:09]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2386913002/#ps100001
(title: ".")

[commit-bot: I haz the power, 2016-10-04 01:57:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 02:40:25]

Description was changed from

==========
content: Remove gpu memory buffer manager from ChildThreadImpl.

Only RenderThreadImpl does anything with the gpu memory buffer manager.
So move it out of ChildThreadImpl into RenderThreadImpl.

This also ensures that if mus is used, then ChildGpuMemoryBufferManager
is not created and accidentally used. This fixes a crash in extensions
using the tab-capture api when running with --use-mus-in-renderer.

BUG=643746
==========

to

==========
content: Remove gpu memory buffer manager from ChildThreadImpl.

Only RenderThreadImpl does anything with the gpu memory buffer manager.
So move it out of ChildThreadImpl into RenderThreadImpl.

This also ensures that if mus is used, then ChildGpuMemoryBufferManager
is not created and accidentally used. This fixes a crash in extensions
using the tab-capture api when running with --use-mus-in-renderer.

BUG=643746
==========

[commit-bot: I haz the power, 2016-10-04 02:40:26]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-10-04 02:42:08]

Description was changed from

==========
content: Remove gpu memory buffer manager from ChildThreadImpl.

Only RenderThreadImpl does anything with the gpu memory buffer manager.
So move it out of ChildThreadImpl into RenderThreadImpl.

This also ensures that if mus is used, then ChildGpuMemoryBufferManager
is not created and accidentally used. This fixes a crash in extensions
using the tab-capture api when running with --use-mus-in-renderer.

BUG=643746
==========

to

==========
content: Remove gpu memory buffer manager from ChildThreadImpl.

Only RenderThreadImpl does anything with the gpu memory buffer manager.
So move it out of ChildThreadImpl into RenderThreadImpl.

This also ensures that if mus is used, then ChildGpuMemoryBufferManager
is not created and accidentally used. This fixes a crash in extensions
using the tab-capture api when running with --use-mus-in-renderer.

BUG=643746

Committed: https://crrev.com/b9ff6c9da80f39e37c8f44cd0f9d8749f0fa377f
Cr-Commit-Position: refs/heads/master@{#422675}
==========

[commit-bot: I haz the power, 2016-10-04 02:42:09]

Patchset 5 (id:??) landed as
https://crrev.com/b9ff6c9da80f39e37c8f44cd0f9d8749f0fa377f
Cr-Commit-Position: refs/heads/master@{#422675}