Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2386893002: Reformat comments in core/html/parser (Closed)

Created:
4 years, 2 months ago by Charlie Harrison
Modified:
4 years, 2 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, Yoav Weiss, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reformat comments in core/html/parser BUG=563793 Committed: https://crrev.com/4e1cadabbfa289b8e565114fe51a32980c996d93 Cr-Commit-Position: refs/heads/master@{#422410}

Patch Set 1 #

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+633 lines, -516 lines) Patch
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 6 chunks +30 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.h View 8 chunks +18 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 19 chunks +81 lines, -69 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 5 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 28 chunks +105 lines, -104 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLElementStack.h View 2 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLEntityParser.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLEntityParserTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.h View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp View 1 4 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLInputStream.h View 5 chunks +20 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLMetaCharsetParser.cpp View 2 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.h View 1 4 chunks +23 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp View 7 chunks +26 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserThread.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 10 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 3 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLSourceTracker.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp View 5 chunks +15 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLStackItem.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLToken.h View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h View 3 chunks +16 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 16 chunks +39 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/InputStreamPreprocessor.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/TextDocumentParser.cpp View 1 chunk +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp View 1 7 chunks +23 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp View 17 chunks +76 lines, -52 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Charlie Harrison
kouhei, PTAL?
4 years, 2 months ago (2016-10-02 02:52:33 UTC) #5
kouhei (in TOK)
rubberstamp lgtm
4 years, 2 months ago (2016-10-03 08:04:21 UTC) #8
Charlie Harrison
Thanks! Landing after a self-review
4 years, 2 months ago (2016-10-03 12:57:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386893002/20001
4 years, 2 months ago (2016-10-03 12:57:30 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 14:09:55 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 14:12:00 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e1cadabbfa289b8e565114fe51a32980c996d93
Cr-Commit-Position: refs/heads/master@{#422410}

Powered by Google App Engine
This is Rietveld 408576698