Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: tracing/tracing/ui/analysis/related_events.html

Issue 2386873002: Implement single/multi V8 GC objects statistics sub view. (Closed)
Patch Set: remove diff Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/analysis/related_events.html
diff --git a/tracing/tracing/ui/analysis/related_events.html b/tracing/tracing/ui/analysis/related_events.html
index 64e6a8f7e422da64881f6994cdc8bd8da75accf2..110fb7fb8b27bce44d1419cdbdae36b892827ea1 100644
--- a/tracing/tracing/ui/analysis/related_events.html
+++ b/tracing/tracing/ui/analysis/related_events.html
@@ -98,6 +98,7 @@ Polymer({
this.cancelAllTasks_();
this.eventGroups_ = [];
this.addRuntimeCallStats_(eventSet);
+ this.addGCObjectStats_(eventSet);
this.addV8Slices_(eventSet);
this.addConnectedFlows_(eventSet);
this.addConnectedEvents_(eventSet);
@@ -296,6 +297,22 @@ Polymer({
}
},
+ addGCObjectStats_: function(eventSet) {
fmeawad 2016/10/04 17:50:55 nit: addV8GCObjectStats_
lpy 2016/10/05 17:44:28 Done.
+ var slices = new tr.model.EventSet;
+ for (var slice of eventSet) {
+ if (slice.title === 'V8.GC_Objects_Stats')
+ slices.push(slice);
+ }
+ if (slices.length > 0) {
+ this.eventGroups_.push({
+ type: 'V8 GC stats table',
+ // eslint-disable-next-line
+ tooltip: 'All V8 slices containing GC statistics in the selected slice(s).',
fmeawad 2016/10/04 17:50:55 nit: selected set.
lpy 2016/10/05 17:44:27 Done.
+ selection: slices
+ });
+ }
+ },
+
updateContents_: function() {
var table = this.$.table;
if (this.eventGroups_ === undefined)

Powered by Google App Engine
This is Rietveld 408576698