Implement single/multi V8 GC objects statistics sub view.

Implement single/multi V8 GC objects statistics sub view.

BUG=catapult:#2881

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c7ea17acbc7b264386d7b2ddca12bb5a6457bf59

[lpy, 2016-10-02 00:17:25]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 00:17:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-10-02 00:18:13]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 00:18:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-10-02 00:18:24]

Patchset #1 (id:1) has been deleted

[lpy, 2016-10-02 00:18:47]

lpy@chromium.org changed reviewers:
+ fmeawad@chromium.org

[lpy, 2016-10-02 00:18:48]

PTAL.

[commit-bot: I haz the power, 2016-10-02 00:40:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-02 00:40:40]

Dry run: This issue passed the CQ dry run.

[fmeawad, 2016-10-03 15:33:40]

It is hard to test this since the V8 changes has not landed, and even tho we
still need to pass some flags for now.

So can you add a link to a raw trace + html trace with this applied to it? and
maybe a screenshot as well?

https://codereview.chromium.org/2386873002/diff/20001/tracing/tracing/ui/extr...
File tracing/tracing/ui/extras/v8/gc_objects_stats_table.html (right):

https://codereview.chromium.org/2386873002/diff/20001/tracing/tracing/ui/extr...
tracing/tracing/ui/extras/v8/gc_objects_stats_table.html:31: var
InstanceTypeGroups = {
Can you add a reference here to where these are synced from? in case of
inconsistencies starts appearing it might be easier to debug.

[lpy, 2016-10-04 17:26:20]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 17:26:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-10-04 17:30:21]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 17:30:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-10-04 17:30:44]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[lpy, 2016-10-04 17:30:51]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-10-04 17:30:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fmeawad, 2016-10-04 17:50:55]

lgtm % some comments

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/anal...
File tracing/tracing/ui/analysis/related_events.html (right):

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/anal...
tracing/tracing/ui/analysis/related_events.html:300: addGCObjectStats_:
function(eventSet) {
nit: addV8GCObjectStats_

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/anal...
tracing/tracing/ui/analysis/related_events.html:310: tooltip: 'All V8 slices
containing GC statistics in the selected slice(s).',
nit: selected set.

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/extr...
File tracing/tracing/ui/extras/v8/gc_objects_stats_table.html (right):

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/extr...
tracing/tracing/ui/extras/v8/gc_objects_stats_table.html:29: var
InstanceTypeGroups = {
We need to move those groups as well as the runtime call stats groups into
chrome/v8 helper classes (i.e. outside of /ui/)
We cannot use them from here when building metrics.

Can be done with the RuntimeCallStats one in a separate CL.

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/extr...
tracing/tracing/ui/extras/v8/gc_objects_stats_table.html:353: function
plusMinus(value, suffix) {
Is this still used?

[commit-bot: I haz the power, 2016-10-04 18:13:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:13:45]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-10-05 17:39:11]

The CQ bit was checked by lpy@chromium.org

[lpy, 2016-10-05 17:39:18]

The CQ bit was unchecked by lpy@chromium.org

[commit-bot: I haz the power, 2016-10-05 17:39:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-10-05 17:44:26]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[lpy, 2016-10-05 17:44:28]

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/anal...
File tracing/tracing/ui/analysis/related_events.html (right):

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/anal...
tracing/tracing/ui/analysis/related_events.html:300: addGCObjectStats_:
function(eventSet) {
On 2016/10/04 17:50:55, fmeawad wrote:
> nit: addV8GCObjectStats_

Done.

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/anal...
tracing/tracing/ui/analysis/related_events.html:310: tooltip: 'All V8 slices
containing GC statistics in the selected slice(s).',
On 2016/10/04 17:50:55, fmeawad wrote:
> nit: selected set.

Done.

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/extr...
File tracing/tracing/ui/extras/v8/gc_objects_stats_table.html (right):

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/extr...
tracing/tracing/ui/extras/v8/gc_objects_stats_table.html:29: var
InstanceTypeGroups = {
On 2016/10/04 17:50:55, fmeawad wrote:
> We need to move those groups as well as the runtime call stats groups into
> chrome/v8 helper classes (i.e. outside of /ui/)
> We cannot use them from here when building metrics.
> 
> Can be done with the RuntimeCallStats one in a separate CL.

Agree.

https://codereview.chromium.org/2386873002/diff/80001/tracing/tracing/ui/extr...
tracing/tracing/ui/extras/v8/gc_objects_stats_table.html:353: function
plusMinus(value, suffix) {
On 2016/10/04 17:50:55, fmeawad wrote:
> Is this still used?

Done.

[commit-bot: I haz the power, 2016-10-05 17:44:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 18:17:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 18:17:22]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-10-05 18:19:58]

The CQ bit was checked by lpy@chromium.org

[lpy, 2016-10-05 18:19:58]

The patchset sent to the CQ was uploaded after l-g-t-m from fmeawad@chromium.org
Link to the patchset: https://codereview.chromium.org/2386873002/#ps100001
(title: "update")

[commit-bot: I haz the power, 2016-10-05 18:20:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 18:21:23]

Description was changed from

==========
Implement single/multi V8 GC objects statistics sub view.

BUG=catapult:#2881
==========

to

==========
Implement single/multi V8 GC objects statistics sub view.

BUG=catapult:#2881

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-10-05 18:21:24]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...