Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2386843002: reflow comments in wtf (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
waxmiguel, dcheng
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in wtf BUG=563793 Committed: https://crrev.com/b68f48701966427c18cbb63e3a15e7dda4fa19a4 Cr-Commit-Position: refs/heads/master@{#422340}

Patch Set 1 #

Total comments: 12

Patch Set 2 : comments (heh!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -320 lines) Patch
M third_party/WebKit/Source/wtf/ASCIICType.h View 1 chunk +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/wtf/AddressSanitizer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/Allocator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.cpp View 4 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/BitVector.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/BloomFilter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/Compiler.h View 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/CryptographicallyRandomNumber.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/CryptographicallyRandomNumber.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/CurrentTime.h View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/DataLog.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/wtf/DateMath.h View 1 chunk +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/DateMath.cpp View 5 chunks +23 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/wtf/DequeTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/DynamicAnnotations.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 3 chunks +26 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/wtf/FunctionalTest.cpp View 3 chunks +9 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashFunctions.h View 7 chunks +16 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashMap.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashMapTest.cpp View 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashSet.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashSetTest.cpp View 4 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashTable.h View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashTraits.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/HexNumber.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/InstanceCounter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/LeakAnnotations.h View 1 1 chunk +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSet.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSetTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/MathExtras.h View 4 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/wtf/MathExtrasTest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/PassRefPtr.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/RefPtr.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/StaticConstructors.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/StdLibExtras.h View 3 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/StringExtras.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/StringHasher.h View 3 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/wtf/StringHasherTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArray.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ThreadRestrictionVerifier.h View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadSpecific.h View 6 chunks +21 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadSpecificWin.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Threading.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingPrimitives.h View 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingPthreads.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingWin.cpp View 1 5 chunks +39 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/wtf/TreeNode.h View 1 chunk +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/TypeTraits.h View 2 chunks +18 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 1 8 chunks +40 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/wtf/VectorTest.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/VectorTraits.h View 3 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/WTF.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/WTF.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/build_config.h View 2 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/dtoa.cpp View 3 chunks +21 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Nico
4 years, 2 months ago (2016-10-01 19:42:30 UTC) #4
dcheng
LGTM with nits https://codereview.chromium.org/2386843002/diff/1/third_party/WebKit/Source/wtf/Assertions.h File third_party/WebKit/Source/wtf/Assertions.h (right): https://codereview.chromium.org/2386843002/diff/1/third_party/WebKit/Source/wtf/Assertions.h#newcode127 third_party/WebKit/Source/wtf/Assertions.h:127: // entry. Nit: move comment to ...
4 years, 2 months ago (2016-10-01 19:58:17 UTC) #5
Nico
Thanks, good finds. https://codereview.chromium.org/2386843002/diff/1/third_party/WebKit/Source/wtf/Assertions.h File third_party/WebKit/Source/wtf/Assertions.h (right): https://codereview.chromium.org/2386843002/diff/1/third_party/WebKit/Source/wtf/Assertions.h#newcode127 third_party/WebKit/Source/wtf/Assertions.h:127: // entry. On 2016/10/01 19:58:17, dcheng ...
4 years, 2 months ago (2016-10-02 00:49:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386843002/20001
4 years, 2 months ago (2016-10-02 00:49:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-02 02:24:26 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b68f48701966427c18cbb63e3a15e7dda4fa19a4 Cr-Commit-Position: refs/heads/master@{#422340}
4 years, 2 months ago (2016-10-02 02:25:47 UTC) #14
waxmiguel
4 years, 2 months ago (2016-10-02 11:39:51 UTC) #16
Message was sent while issue was closed. 
Cheers

Powered by Google App Engine
This is Rietveld 408576698