Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: extensions/browser/extension_function.h

Issue 2386823002: [Extensions] Remove ExtensionFunction::SetError() (Closed)
Patch Set: lazyboy's Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_function.h
diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h
index 03d6572921f0de46ca07eee9379afbae216bbebf..dee9a4fe16ea0e27ceab6bf173f25dfdd8d04154 100644
--- a/extensions/browser/extension_function.h
+++ b/extensions/browser/extension_function.h
@@ -243,10 +243,6 @@ class ExtensionFunction
// Retrieves any error string from the function.
virtual const std::string& GetError() const;
- // Sets the function's error string.
- // TODO(devlin): This should be handled exclusively through the responses.
- virtual void SetError(const std::string& error);
-
bool bad_message() const { return bad_message_; }
void set_bad_message(bool bad_message) { bad_message_ = bad_message; }
@@ -636,8 +632,9 @@ class AsyncExtensionFunction : public UIThreadExtensionFunction {
public:
AsyncExtensionFunction();
+ void SetError(const std::string& error);
+
// ExtensionFunction:
- void SetError(const std::string& error) override;
const std::string& GetError() const override;
protected:
« no previous file with comments | « chrome/test/data/extensions/api_test/input_ime/background.js ('k') | extensions/browser/extension_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698