[Extensions] Remove ExtensionFunction::SetError()

extensions/browser/extension_function.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_EXTENSION_FUNCTION_H_
 #define EXTENSIONS_BROWSER_EXTENSION_FUNCTION_H_
 
 #include <stddef.h>
 
 #include <list>
@@ skipping 225 matching lines @@
   // Specifies the raw arguments to the function, as a JSON value.
   // TODO(dcheng): This should take a const ref.
   virtual void SetArgs(const base::ListValue* args);
 
   // Retrieves the results of the function as a ListValue.
   const base::ListValue* GetResultList() const;
 
   // Retrieves any error string from the function.
   virtual const std::string& GetError() const;
 
-  // Sets the function's error string.
-  // TODO(devlin): This should be handled exclusively through the responses.
-  virtual void SetError(const std::string& error);
-
   bool bad_message() const { return bad_message_; }
   void set_bad_message(bool bad_message) { bad_message_ = bad_message; }
 
   // Specifies the name of the function. A long-lived string (such as a string
   // literal) must be provided.
   void set_name(const char* name) { name_ = name; }
   const char* name() const { return name_; }
 
   void set_profile_id(void* profile_id) { profile_id_ = profile_id; }
   void* profile_id() const { return profile_id_; }
@@ skipping 370 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(IOThreadExtensionFunction);
 };
 
 // Base class for an extension function that runs asynchronously *relative to
 // the browser's UI thread*.
 class AsyncExtensionFunction : public UIThreadExtensionFunction {
  public:
   AsyncExtensionFunction();
 
   // ExtensionFunction:
-  void SetError(const std::string& error) override;
+  void SetError(const std::string& error);

[lazyboy, 2016/10/03 20:34:01]

Same here.

[Devlin, 2016/10/03 23:07:50]

Done.

   const std::string& GetError() const override;
 
  protected:
   ~AsyncExtensionFunction() override;
 
   // Sets a single Value as the results of the function.
   void SetResult(std::unique_ptr<base::Value> result);
 
   // Sets multiple Values as the results of the function.
   void SetResultList(std::unique_ptr<base::ListValue> results);
@@ skipping 23 matching lines @@
  private:
   // If you're hitting a compile error here due to "final" - great! You're
   // doing the right thing, you just need to extend UIThreadExtensionFunction
   // instead of AsyncExtensionFunction.
   ResponseAction Run() final;
 
   DISALLOW_COPY_AND_ASSIGN(AsyncExtensionFunction);
 };
 
 #endif  // EXTENSIONS_BROWSER_EXTENSION_FUNCTION_H_