[Extensions] Remove ExtensionFunction::SetError()

chrome/browser/extensions/api/input_ime/input_ime_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/input_ime/input_ime_api.h"
 
 #include "base/lazy_instance.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/common/extensions/api/input_ime.h"
 #include "content/public/browser/notification_registrar.h"
@@ skipping 265 matching lines @@
   InputMethodEngineBase* engine =
       event_router ? event_router->GetActiveEngine(extension_id()) : nullptr;
   if (engine) {
     engine->KeyEventHandled(extension_id(), params->request_id,
                             params->response);
   }
   return RespondNow(NoArguments());
 }
 
 ExtensionFunction::ResponseAction InputImeSetCompositionFunction::Run() {
-  bool success = false;
   InputImeEventRouter* event_router =
       GetInputImeEventRouter(Profile::FromBrowserContext(browser_context()));
   InputMethodEngineBase* engine =
       event_router ? event_router->GetActiveEngine(extension_id()) : nullptr;
   if (engine) {
     std::unique_ptr<SetComposition::Params> parent_params(
         SetComposition::Params::Create(*args_));
     const SetComposition::Params::Parameters& params =
         parent_params->parameters;
     std::vector<InputMethodEngineBase::SegmentInfo> segments;
@@ skipping 15 matching lines @@
               InputMethodEngineBase::SEGMENT_STYLE_NO_UNDERLINE;
         }
         segments.push_back(segment_info);
       }
     }
     int selection_start =
         params.selection_start ? *params.selection_start : params.cursor;
     int selection_end =
         params.selection_end ? *params.selection_end : params.cursor;
     std::string error;
-    success = engine->SetComposition(params.context_id, params.text.c_str(),
-                                     selection_start, selection_end,
-                                     params.cursor, segments, &error);
-    SetError(error);
+    if (!engine->SetComposition(params.context_id, params.text.c_str(),
+                                selection_start, selection_end, params.cursor,
+                                segments, &error)) {
+      std::unique_ptr<base::ListValue> results =
+          base::MakeUnique<base::ListValue>();
+      results->Append(base::MakeUnique<base::FundamentalValue>(false));
+      return RespondNow(ErrorWithArguments(std::move(results), error));
+    }
   }
-  std::unique_ptr<base::ListValue> output =
-      SetComposition::Results::Create(success);
-  return RespondNow(ArgumentList(std::move(output)));
+  return RespondNow(
+      OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
 }
 
 ExtensionFunction::ResponseAction InputImeCommitTextFunction::Run() {
-  bool success = false;
   InputImeEventRouter* event_router =
       GetInputImeEventRouter(Profile::FromBrowserContext(browser_context()));
   InputMethodEngineBase* engine =
       event_router ? event_router->GetActiveEngine(extension_id()) : nullptr;
   if (engine) {
     std::unique_ptr<CommitText::Params> parent_params(
         CommitText::Params::Create(*args_));
     const CommitText::Params::Parameters& params = parent_params->parameters;
     std::string error;
-    success =
-        engine->CommitText(params.context_id, params.text.c_str(), &error);
-    SetError(error);
+    if (!engine->CommitText(params.context_id, params.text.c_str(), &error)) {
+      std::unique_ptr<base::ListValue> results =
+          base::MakeUnique<base::ListValue>();
+      results->Append(base::MakeUnique<base::FundamentalValue>(false));
+      return RespondNow(ErrorWithArguments(std::move(results), error));
+    }
   }
-  std::unique_ptr<base::ListValue> output =
-      CommitText::Results::Create(success);
-  return RespondNow(ArgumentList(std::move(output)));
+  return RespondNow(
+      OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
 }
 
 ExtensionFunction::ResponseAction InputImeSendKeyEventsFunction::Run() {
   InputImeEventRouter* event_router =
       GetInputImeEventRouter(Profile::FromBrowserContext(browser_context()));
   InputMethodEngineBase* engine =
       event_router ? event_router->GetActiveEngine(extension_id()) : nullptr;
   if (!engine)
     return RespondNow(Error(kErrorEngineNotAvailable));
 
@@ skipping 54 matching lines @@
 InputImeEventRouter* GetInputImeEventRouter(Profile* profile) {
   if (!profile)
     return nullptr;
   if (profile->HasOffTheRecordProfile())
     profile = profile->GetOffTheRecordProfile();
   return extensions::InputImeEventRouterFactory::GetInstance()->GetRouter(
       profile);
 }
 
 }  // namespace extensions