|
|
Chromium Code Reviews
DescriptionUse net::TestNetworkQualityEstimator for data reduction proxy tests
Currently, data reduction proxy tests use their own
TestNetworkQualityEstimator which is unnecessary.
BUG=654444
TBR=bengr@chromium.org
Committed: https://crrev.com/785a6ab5d6e0d43dfb87b3df98b504825074b26a
Cr-Commit-Position: refs/heads/master@{#424218}
Patch Set 1 : ps #
Messages
Total messages: 40 (30 generated)
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Description was changed from ========== Use net::TestNetworkQualityEstimator for data reduction prxoy tests BUG= ========== to ========== Use net::TestNetworkQualityEstimator for data reduction proxy tests BUG= ==========
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
Patchset #1 (id:1) has been deleted
tbansal@chromium.org changed reviewers: + megjablon@chromium.org
megjablon: ptal at *. Thanks.
Description was changed from ========== Use net::TestNetworkQualityEstimator for data reduction proxy tests BUG= ========== to ========== Use net::TestNetworkQualityEstimator for data reduction proxy tests Currently, data reduction proxy tests use their own TestNetworkQualityEstimator which is unnecessary. BUG= ==========
megjablon: ping.
lgtm
Description was changed from ========== Use net::TestNetworkQualityEstimator for data reduction proxy tests Currently, data reduction proxy tests use their own TestNetworkQualityEstimator which is unnecessary. BUG= ========== to ========== Use net::TestNetworkQualityEstimator for data reduction proxy tests Currently, data reduction proxy tests use their own TestNetworkQualityEstimator which is unnecessary. BUG=654444 ==========
tbansal@chromium.org changed reviewers: + mmenke@chromium.org
mmenke: ptal at gn and gyp. Thanks.
On 2016/10/10 16:20:35, tbansal1 wrote: > mmenke: ptal at gn and gyp. Thanks. LGTM
Description was changed from ========== Use net::TestNetworkQualityEstimator for data reduction proxy tests Currently, data reduction proxy tests use their own TestNetworkQualityEstimator which is unnecessary. BUG=654444 ========== to ========== Use net::TestNetworkQualityEstimator for data reduction proxy tests Currently, data reduction proxy tests use their own TestNetworkQualityEstimator which is unnecessary. BUG=654444 TBR=bengr@chromium.org ==========
tbansal@chromium.org changed reviewers: + bengr@chromium.org
tbansal@chromium.org changed reviewers: - bengr@chromium.org
TBR'ing bengr for the mechanical changes in network_quality_estimator_test_util.h.
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use net::TestNetworkQualityEstimator for data reduction proxy tests Currently, data reduction proxy tests use their own TestNetworkQualityEstimator which is unnecessary. BUG=654444 TBR=bengr@chromium.org ========== to ========== Use net::TestNetworkQualityEstimator for data reduction proxy tests Currently, data reduction proxy tests use their own TestNetworkQualityEstimator which is unnecessary. BUG=654444 TBR=bengr@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Use net::TestNetworkQualityEstimator for data reduction proxy tests Currently, data reduction proxy tests use their own TestNetworkQualityEstimator which is unnecessary. BUG=654444 TBR=bengr@chromium.org ========== to ========== Use net::TestNetworkQualityEstimator for data reduction proxy tests Currently, data reduction proxy tests use their own TestNetworkQualityEstimator which is unnecessary. BUG=654444 TBR=bengr@chromium.org Committed: https://crrev.com/785a6ab5d6e0d43dfb87b3df98b504825074b26a Cr-Commit-Position: refs/heads/master@{#424218} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/785a6ab5d6e0d43dfb87b3df98b504825074b26a Cr-Commit-Position: refs/heads/master@{#424218} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
