Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2386813003: Use net::TestNetworkQualityEstimator for data reduction proxy tests (Closed)

Created:
4 years, 2 months ago by tbansal1
Modified:
4 years, 2 months ago
Reviewers:
mmenke, megjablon
CC:
chromium-reviews, cbentzel+watch_chromium.org, bengr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use net::TestNetworkQualityEstimator for data reduction proxy tests Currently, data reduction proxy tests use their own TestNetworkQualityEstimator which is unnecessary. BUG=654444 TBR=bengr@chromium.org Committed: https://crrev.com/785a6ab5d6e0d43dfb87b3df98b504825074b26a Cr-Commit-Position: refs/heads/master@{#424218}

Patch Set 1 : ps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -84 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc View 8 chunks +15 lines, -55 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 4 chunks +8 lines, -26 lines 0 comments Download
M net/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M net/nqe/network_quality_estimator_test_util.h View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 40 (30 generated)
tbansal1
megjablon: ptal at *. Thanks.
4 years, 2 months ago (2016-10-04 02:37:44 UTC) #22
tbansal1
megjablon: ping.
4 years, 2 months ago (2016-10-07 15:40:40 UTC) #24
megjablon
lgtm
4 years, 2 months ago (2016-10-07 21:26:38 UTC) #25
tbansal1
4 years, 2 months ago (2016-10-10 16:20:06 UTC) #28
tbansal1
mmenke: ptal at gn and gyp. Thanks.
4 years, 2 months ago (2016-10-10 16:20:35 UTC) #29
mmenke
On 2016/10/10 16:20:35, tbansal1 wrote: > mmenke: ptal at gn and gyp. Thanks. LGTM
4 years, 2 months ago (2016-10-10 16:24:27 UTC) #30
tbansal1
TBR'ing bengr for the mechanical changes in network_quality_estimator_test_util.h.
4 years, 2 months ago (2016-10-10 18:18:40 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386813003/60001
4 years, 2 months ago (2016-10-10 18:19:13 UTC) #36
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 2 months ago (2016-10-10 20:19:52 UTC) #38
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 20:22:13 UTC) #40
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/785a6ab5d6e0d43dfb87b3df98b504825074b26a
Cr-Commit-Position: refs/heads/master@{#424218}

Powered by Google App Engine
This is Rietveld 408576698