Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3896)

Unified Diff: chrome/browser/managed_mode/managed_user_service_unittest.cc

Issue 23868042: Mark supervised profiles as such immediately when they're created. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/managed_mode/managed_user_service_unittest.cc
diff --git a/chrome/browser/managed_mode/managed_user_service_unittest.cc b/chrome/browser/managed_mode/managed_user_service_unittest.cc
index c8d5e105b1afd5209599b968a50989bb584379ec..341354f135cbf53652dee2ffe6933a5c51fe2866 100644
--- a/chrome/browser/managed_mode/managed_user_service_unittest.cc
+++ b/chrome/browser/managed_mode/managed_user_service_unittest.cc
@@ -18,7 +18,7 @@
#include "chrome/common/extensions/extension_builder.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_profile.h"
-#include "content/public/test/test_browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/test_utils.h"
#include "extensions/common/manifest_constants.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -60,16 +60,14 @@ class ManagedModeURLFilterObserver : public ManagedModeURLFilter::Observer {
class ManagedUserServiceTest : public ::testing::Test {
public:
- ManagedUserServiceTest() : ui_thread_(content::BrowserThread::UI,
- &message_loop_) {
+ ManagedUserServiceTest() {
managed_user_service_ = ManagedUserServiceFactory::GetForProfile(&profile_);
}
virtual ~ManagedUserServiceTest() {}
protected:
- base::MessageLoop message_loop_;
- content::TestBrowserThread ui_thread_;
+ content::TestBrowserThreadBundle thread_bundle_;
TestingProfile profile_;
ManagedUserService* managed_user_service_;
};
@@ -133,18 +131,19 @@ TEST_F(ManagedUserServiceTest, GetManualExceptionsForHost) {
managed_user_service_->GetManualBehaviorForURL(kMooseURL));
}
-class ManagedUserServiceExtensionTest : public ExtensionServiceTestBase {
+class ManagedUserServiceExtensionTestBase : public ExtensionServiceTestBase {
public:
- ManagedUserServiceExtensionTest() {}
- virtual ~ManagedUserServiceExtensionTest() {}
+ explicit ManagedUserServiceExtensionTestBase(bool is_managed)
+ : is_managed_(is_managed) {}
+ virtual ~ManagedUserServiceExtensionTestBase() {}
virtual void SetUp() OVERRIDE {
ExtensionServiceTestBase::SetUp();
- InitializeEmptyExtensionService();
- }
-
- virtual void TearDown() OVERRIDE {
- ExtensionServiceTestBase::TearDown();
+ ExtensionServiceTestBase::ExtensionServiceInitParams params;
+ params.profile_is_managed = is_managed_;
+ InitializeExtensionServiceParams(&params);
+ InitializeExtensionService(params);
+ ManagedUserServiceFactory::GetForProfile(profile_.get())->Init();
}
protected:
@@ -174,10 +173,26 @@ class ManagedUserServiceExtensionTest : public ExtensionServiceTestBase {
builder.SetManifest(manifest.Pass()).Build();
return extension;
}
+
+ bool is_managed_;
+};
+
+class ManagedUserServiceExtensionTestUnmanaged
+ : public ManagedUserServiceExtensionTestBase {
+ public:
+ ManagedUserServiceExtensionTestUnmanaged()
+ : ManagedUserServiceExtensionTestBase(false) {}
};
-TEST_F(ManagedUserServiceExtensionTest,
- ExtensionManagementPolicyProviderUnmanaged) {
+class ManagedUserServiceExtensionTest
+ : public ManagedUserServiceExtensionTestBase {
+ public:
+ ManagedUserServiceExtensionTest()
+ : ManagedUserServiceExtensionTestBase(true) {}
+};
+
+TEST_F(ManagedUserServiceExtensionTestUnmanaged,
+ ExtensionManagementPolicyProvider) {
ManagedUserService* managed_user_service =
ManagedUserServiceFactory::GetForProfile(profile_.get());
EXPECT_FALSE(profile_->IsManaged());
@@ -193,11 +208,9 @@ TEST_F(ManagedUserServiceExtensionTest,
EXPECT_EQ(string16(), error_2);
}
-TEST_F(ManagedUserServiceExtensionTest,
- ExtensionManagementPolicyProviderManaged) {
+TEST_F(ManagedUserServiceExtensionTest, ExtensionManagementPolicyProvider) {
ManagedUserService* managed_user_service =
ManagedUserServiceFactory::GetForProfile(profile_.get());
- managed_user_service->InitForTesting();
ManagedModeURLFilterObserver observer(
managed_user_service->GetURLFilterForUIThread());
EXPECT_TRUE(profile_->IsManaged());
@@ -228,11 +241,9 @@ TEST_F(ManagedUserServiceExtensionTest,
#endif
}
-
TEST_F(ManagedUserServiceExtensionTest, NoContentPacks) {
ManagedUserService* managed_user_service =
ManagedUserServiceFactory::GetForProfile(profile_.get());
- managed_user_service->Init();
ManagedModeURLFilter* url_filter =
managed_user_service->GetURLFilterForUIThread();
@@ -247,7 +258,6 @@ TEST_F(ManagedUserServiceExtensionTest, NoContentPacks) {
TEST_F(ManagedUserServiceExtensionTest, InstallContentPacks) {
ManagedUserService* managed_user_service =
ManagedUserServiceFactory::GetForProfile(profile_.get());
- managed_user_service->InitForTesting();
ManagedModeURLFilter* url_filter =
managed_user_service->GetURLFilterForUIThread();
ManagedModeURLFilterObserver observer(url_filter);

Powered by Google App Engine
This is Rietveld 408576698