ui/gl/gl_implementation_osmesa.h - Issue 23868030: Make it possible to use OSMesa on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gl/gl_implementation_osmesa.h

Issue 23868030: Make it possible to use OSMesa on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #ifndef UI_GL_GL_IMPLEMENTATION_OSMESA_

	6 #define UI_GL_GL_IMPLEMENTATION_OSMESA_

	7

5 #include "base/files/file_path.h"	8 #include "base/files/file_path.h"

6 #include "base/native_library.h"	9 #include "base/native_library.h"

7	10

8 namespace gfx {	11 namespace gfx {

9	12

10 bool InitializeGLBindingsOSMesaGL();	13 bool InitializeGLBindingsOSMesaGL();

11 base::NativeLibrary LoadLibrary(const char* filename);	14 base::NativeLibrary LoadLibrary(const char* filename);

12 base::NativeLibrary LoadLibrary(const base::FilePath& filename);	15 base::NativeLibrary LoadLibrary(const base::FilePath& filename);
	no sievers 2013/10/04 21:48:54 Do the LoadLibrary function maybe fit better into Do the LoadLibrary function maybe fit better into gl_implementation.h/.cc? They are not really specific to Mesa and also used to load other (e.g. EGL) libraries. Peter Beverloo 2013/10/25 15:40:55 They feel like base/-level methods to me. I'd pre Show quoted text On 2013/10/04 21:48:54, sievers wrote: > Do the LoadLibrary function maybe fit better into gl_implementation.h/.cc? > They are not really specific to Mesa and also used to load other (e.g. EGL) > libraries. They feel like base/-level methods to me. I'd prefer to limit exposure as far as we can, or formally move them to ui/base/. no sievers 2013/10/25 19:08:13 It just felt a bit weird that gl_implementation_an Show quoted text On 2013/10/25 15:40:55, Peter Beverloo wrote: > On 2013/10/04 21:48:54, sievers wrote: > > Do the LoadLibrary function maybe fit better into gl_implementation.h/.cc? > > They are not really specific to Mesa and also used to load other (e.g. EGL) > > libraries. > > They feel like base/-level methods to me. I'd prefer to limit exposure as far > as we can, or formally move them to ui/base/. It just felt a bit weird that gl_implementation_android.cc needs to include gl_implementation_osmesa.h regardless of osmesa-specific functionality. Now that I look at them, the functions don't look very useful anyways (one is a one-liner, the other one adds a VLOG on failure), so you could probably also just remove/inline them.
13	16

14 } // namespace gfx	17 } // namespace gfx

	18

	19 #endif // UI_GL_GL_IMPLEMENTATION_OSMESA_

OLD	NEW

« no previous file with comments | « ui/gl/gl_implementation_linux.cc ('k') | ui/gl/gl_implementation_osmesa.cc » ('j') | no next file with comments »