Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 23868025: line up crashing with chrome (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/platform.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-win32.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcarney
7 years, 3 months ago (2013-09-13 11:17:47 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-09-13 12:32:32 UTC) #2
dcarney
Committed patchset #1 manually as r16717 (presubmit successful).
7 years, 3 months ago (2013-09-13 12:50:08 UTC) #3
Jakob Kummerow
7 years, 3 months ago (2013-09-14 10:13:54 UTC) #4
Message was sent while issue was closed.
DBC: Looks like we can remove --nobreak-on-abort from MODE_FLAGS in
tools/run-tests.py then.

Powered by Google App Engine
This is Rietveld 408576698