Use the top-level URL for popup blocking.

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <utility>
 #include <vector>
 
@@ skipping 1937 matching lines @@
       DesktopNotificationServiceFactory::GetForProfile(profile);
   service->CancelDesktopNotification(
       render_process_id, render_view_id, notification_id);
 #else
   NOTIMPLEMENTED();
 #endif
 }
 
 bool ChromeContentBrowserClient::CanCreateWindow(
     const GURL& opener_url,
+    const GURL& opener_top_level_frame_url,
     const GURL& source_origin,
     WindowContainerType container_type,
     const GURL& target_url,
     const content::Referrer& referrer,
     WindowOpenDisposition disposition,
     const WebWindowFeatures& features,
     bool user_gesture,
     bool opener_suppressed,
     content::ResourceContext* context,
     int render_process_id,
@@ skipping 46 matching lines @@
   }
 
   if (is_guest)
     return true;
 
   HostContentSettingsMap* content_settings =
       ProfileIOData::FromResourceContext(context)->GetHostContentSettingsMap();
 
   if (!user_gesture && !CommandLine::ForCurrentProcess()->HasSwitch(
         switches::kDisablePopupBlocking)) {
-    if (content_settings->GetContentSetting(opener_url,
-                                            opener_url,
+    if (content_settings->GetContentSetting(opener_top_level_frame_url,
+                                            opener_top_level_frame_url,

[Bernhard Bauer, 2013/09/11 16:37:46]

Should we pass the |opener_url| as one of the parameters here?

[jochen (gone - plz use gerrit), 2013/09/11 16:45:25]

We can consider that in a future cl. For now, I want to restore the original
behavior.

                                             CONTENT_SETTINGS_TYPE_POPUPS,
                                             std::string()) ==
         CONTENT_SETTING_ALLOW) {
       return true;
     }
 
     BrowserThread::PostTask(BrowserThread::UI,
                             FROM_HERE,
                             base::Bind(&HandleBlockedPopupOnUIThread,
                                        BlockedPopupParams(target_url,
@@ skipping 505 matching lines @@
 #if defined(USE_NSS)
 crypto::CryptoModuleBlockingPasswordDelegate*
     ChromeContentBrowserClient::GetCryptoPasswordDelegate(
         const GURL& url) {
   return chrome::NewCryptoModuleBlockingDialogDelegate(
       chrome::kCryptoModulePasswordKeygen, url.host());
 }
 #endif
 
 }  // namespace chrome