chrome/browser/tab_contents/spelling_menu_observer.cc - Issue 23868013: Refactor dependency on Profile to BrowserContext in spell check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/spelling_menu_observer.cc

Issue 23868013: Refactor dependency on Profile to BrowserContext in spell check. (Closed) Base URL: http://src.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/dictionary_helper.cc ('k') | chrome/browser/ui/webui/options/language_dictionary_overlay_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/spelling_menu_observer.cc

===================================================================

--- chrome/browser/tab_contents/spelling_menu_observer.cc (revision 223601)

+++ chrome/browser/tab_contents/spelling_menu_observer.cc (working copy)

@@ -155,7 +155,7 @@

// |spellcheck_service| can be null when the suggested word is

// provided by Web SpellCheck API.

SpellcheckService* spellcheck_service =

- SpellcheckServiceFactory::GetForProfile(profile);

+ SpellcheckServiceFactory::GetForContext(profile);

if (spellcheck_service && spellcheck_service->GetMetrics())

spellcheck_service->GetMetrics()->RecordSuggestionStats(1);

}

@@ -260,7 +260,7 @@

Profile* profile = proxy_->GetProfile();

if (profile) {

SpellcheckService* spellcheck =

- SpellcheckServiceFactory::GetForProfile(profile);

+ SpellcheckServiceFactory::GetForContext(profile);

if (spellcheck) {

if (spellcheck->GetMetrics())

spellcheck->GetMetrics()->RecordReplacedWordStats(1);

@@ -286,7 +286,7 @@

Profile* profile = proxy_->GetProfile();

if (profile) {

SpellcheckService* spellcheck =

- SpellcheckServiceFactory::GetForProfile(profile);

+ SpellcheckServiceFactory::GetForContext(profile);

if (spellcheck) {

spellcheck->GetCustomDictionary()->AddWord(UTF16ToUTF8(

misspelled_word_));

@@ -359,7 +359,7 @@

if (!profile)

return;

SpellcheckService* spellcheck =

- SpellcheckServiceFactory::GetForProfile(profile);

+ SpellcheckServiceFactory::GetForContext(profile);

if (!spellcheck)

return;

spellcheck->GetFeedbackSender()->IgnoredSuggestions(misspelling_hash_);