Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/spellchecker/spellcheck_factory.h

Issue 23868013: Refactor dependency on Profile to BrowserContext in spell check. (Closed) Base URL: http://src.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_ 5 #ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_
6 #define CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_ 6 #define CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
10 #include "components/browser_context_keyed_service/browser_context_keyed_service _factory.h" 10 #include "components/browser_context_keyed_service/browser_context_keyed_service _factory.h"
11 11
12 class SpellcheckService; 12 class SpellcheckService;
13 class Profile;
14 13
15 // Entry into the SpellCheck system. 14 // Entry into the SpellCheck system.
16 // 15 //
17 // Internally, this owns all SpellcheckService objects. 16 // Internally, this owns all SpellcheckService objects.
18 class SpellcheckServiceFactory : public BrowserContextKeyedServiceFactory { 17 class SpellcheckServiceFactory : public BrowserContextKeyedServiceFactory {
19 public: 18 public:
20 // Returns the spell check host. This will create the SpellcheckService if it 19 // Returns the spell check host. This will create the SpellcheckService
21 // does not already exist. 20 // if it does not already exist. This can return NULL.
22 static SpellcheckService* GetForProfile(Profile* profile); 21 static SpellcheckService* GetForContext(content::BrowserContext* context);
23 22
24 static SpellcheckService* GetForRenderProcessId(int render_process_id); 23 static SpellcheckService* GetForRenderProcessId(int render_process_id);
25 24
26 // Returns the spell check host. This can return NULL.
27 static SpellcheckService* GetForProfileWithoutCreating(Profile* profile);
28
29 static SpellcheckServiceFactory* GetInstance(); 25 static SpellcheckServiceFactory* GetInstance();
30 26
31 private: 27 private:
32 friend struct DefaultSingletonTraits<SpellcheckServiceFactory>; 28 friend struct DefaultSingletonTraits<SpellcheckServiceFactory>;
33 29
34 SpellcheckServiceFactory(); 30 SpellcheckServiceFactory();
35 virtual ~SpellcheckServiceFactory(); 31 virtual ~SpellcheckServiceFactory();
36 32
37 // BrowserContextKeyedServiceFactory: 33 // BrowserContextKeyedServiceFactory:
38 virtual BrowserContextKeyedService* BuildServiceInstanceFor( 34 virtual BrowserContextKeyedService* BuildServiceInstanceFor(
39 content::BrowserContext* context) const OVERRIDE; 35 content::BrowserContext* context) const OVERRIDE;
40 virtual void RegisterProfilePrefs( 36 virtual void RegisterProfilePrefs(
41 user_prefs::PrefRegistrySyncable* registry) OVERRIDE; 37 user_prefs::PrefRegistrySyncable* registry) OVERRIDE;
42 virtual content::BrowserContext* GetBrowserContextToUse( 38 virtual content::BrowserContext* GetBrowserContextToUse(
43 content::BrowserContext* context) const OVERRIDE; 39 content::BrowserContext* context) const OVERRIDE;
44 virtual bool ServiceIsNULLWhileTesting() const OVERRIDE; 40 virtual bool ServiceIsNULLWhileTesting() const OVERRIDE;
45 41
46 DISALLOW_COPY_AND_ASSIGN(SpellcheckServiceFactory); 42 DISALLOW_COPY_AND_ASSIGN(SpellcheckServiceFactory);
47 }; 43 };
48 44
49 #endif // CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_ 45 #endif // CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698