Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2386743002: Cache linked bundles for Bazel packages in files.. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cache linked bundles for Bazel packages in files.. Also verify unlinked bundles consistency with the majorVersion. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6dd774458447d9d536d07ff3408b9e48f85f6506

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -6 lines) Patch
M pkg/analyzer/lib/src/summary/bazel_summary.dart View 10 chunks +146 lines, -2 lines 4 comments Download
M pkg/analyzer/test/src/summary/bazel_summary_test.dart View 5 chunks +136 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 2 months ago (2016-09-30 20:23:58 UTC) #1
Paul Berry
https://codereview.chromium.org/2386743002/diff/1/pkg/analyzer/lib/src/summary/bazel_summary.dart File pkg/analyzer/lib/src/summary/bazel_summary.dart (right): https://codereview.chromium.org/2386743002/diff/1/pkg/analyzer/lib/src/summary/bazel_summary.dart#newcode408 pkg/analyzer/lib/src/summary/bazel_summary.dart:408: // File file = linkedCacheFolder.getChildAssumingFile(fileName); Remove commented out lines ...
4 years, 2 months ago (2016-09-30 20:30:47 UTC) #2
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-09-30 20:32:25 UTC) #3
scheglov
https://codereview.chromium.org/2386743002/diff/1/pkg/analyzer/lib/src/summary/bazel_summary.dart File pkg/analyzer/lib/src/summary/bazel_summary.dart (right): https://codereview.chromium.org/2386743002/diff/1/pkg/analyzer/lib/src/summary/bazel_summary.dart#newcode408 pkg/analyzer/lib/src/summary/bazel_summary.dart:408: // File file = linkedCacheFolder.getChildAssumingFile(fileName); On 2016/09/30 20:30:47, Paul ...
4 years, 2 months ago (2016-09-30 20:38:29 UTC) #4
scheglov
4 years, 2 months ago (2016-09-30 20:40:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6dd774458447d9d536d07ff3408b9e48f85f6506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698