Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(722)

Issue 2386733002: Remove stl_util's deletion functions from remoting/. (Closed)

Created:
3 years, 10 months ago by Avi (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
Sergey Ulanov, Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion functions from remoting/. BUG=555865 Committed: https://crrev.com/c58e7851331d1740dc6bf31ba9cc1c19b842637a Cr-Commit-Position: refs/heads/master@{#422304}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -48 lines) Patch
M remoting/base/buffered_socket_writer.h View 3 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/buffered_socket_writer.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M remoting/protocol/channel_multiplexer.h View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/protocol/channel_multiplexer.cc View 1 8 chunks +15 lines, -21 lines 0 comments Download
M remoting/protocol/message_decoder_unittest.cc View 5 chunks +5 lines, -9 lines 0 comments Download
M remoting/protocol/message_reader_unittest.cc View 1 2 7 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Avi (use Gerrit)
3 years, 10 months ago (2016-09-30 21:27:49 UTC) #12
Sergey Ulanov
lgtm
3 years, 10 months ago (2016-09-30 22:41:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386733002/40001
3 years, 10 months ago (2016-10-01 05:53:26 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 10 months ago (2016-10-01 05:58:19 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2016-10-01 06:00:41 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c58e7851331d1740dc6bf31ba9cc1c19b842637a
Cr-Commit-Position: refs/heads/master@{#422304}

Powered by Google App Engine
This is Rietveld 408576698