Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(98)

Issue 2386723002: Add Explicit Argument Guidance for time.h (Closed)

Created:
3 years ago by robliao
Modified:
3 years ago
Reviewers:
danakj
CC:
chromium-reviews, gab, fdoray
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Explicit Argument Guidance for time.h This is similar to what is provided by StringPiece. BUG= Committed: https://crrev.com/b647179e487049dd2369ccdcea20bdc516e3fff5 Cr-Commit-Position: refs/heads/master@{#422241}

Patch Set 1 #

Total comments: 4

Patch Set 2 : CR Feedback #

Total comments: 2

Patch Set 3 : Update Wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M base/time/time.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
robliao
3 years ago (2016-09-30 19:50:02 UTC) #2
danakj
https://codereview.chromium.org/2386723002/diff/1/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/2386723002/diff/1/base/time/time.h#newcode25 base/time/time.h:25: // instance. Thus, they can be efficiently passed by-value ...
3 years ago (2016-09-30 19:57:47 UTC) #3
robliao
https://codereview.chromium.org/2386723002/diff/1/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/2386723002/diff/1/base/time/time.h#newcode25 base/time/time.h:25: // instance. Thus, they can be efficiently passed by-value ...
3 years ago (2016-09-30 20:03:06 UTC) #4
danakj
LGTM but lets make it less redundant? https://codereview.chromium.org/2386723002/diff/20001/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/2386723002/diff/20001/base/time/time.h#newcode28 base/time/time.h:28: // Prefer ...
3 years ago (2016-09-30 20:18:56 UTC) #5
robliao
https://codereview.chromium.org/2386723002/diff/20001/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/2386723002/diff/20001/base/time/time.h#newcode28 base/time/time.h:28: // Prefer passing these classes by value: On 2016/09/30 ...
3 years ago (2016-09-30 20:26:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386723002/40001
3 years ago (2016-09-30 20:27:31 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years ago (2016-09-30 22:25:55 UTC) #10
commit-bot: I haz the power
3 years ago (2016-09-30 22:28:26 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b647179e487049dd2369ccdcea20bdc516e3fff5
Cr-Commit-Position: refs/heads/master@{#422241}

Powered by Google App Engine
This is Rietveld 408576698