Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4404)

Unified Diff: chrome/common/extensions/docs/server2/manifest_features.py

Issue 23867003: Docserver: Consolidate features caching and access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: let's try this again, shall we? Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/manifest_features.py
diff --git a/chrome/common/extensions/docs/server2/manifest_features.py b/chrome/common/extensions/docs/server2/manifest_features.py
index e535592482fec1c804afd4ac82951356528114a5..ef5a7ab9f1609d64af8ab499ecb4008bda9ab76c 100644
--- a/chrome/common/extensions/docs/server2/manifest_features.py
+++ b/chrome/common/extensions/docs/server2/manifest_features.py
@@ -12,24 +12,6 @@ indicating how an app or extension should define a manifest property. If 'level'
is missing, 'optional' is assumed.
'''
-import features_utility
-
-def CreateManifestFeatures(features_json, manifest_json, filter_platform=None):
- '''Create a manifest features dictionary by normalizing |features_json| and
- merging it with |manifest_json|. If filter_platform is 'app' or 'extension'
- then irrelevant features will be removed.
- '''
- assert filter_platform in ['app', 'extension', None]
- manifest_features = features_utility.MergedWith(
- features_utility.Parse(features_json), manifest_json)
-
- if filter_platform:
- manifest_features = features_utility.Filtered(
- manifest_features, filter_platform)
-
- return manifest_features
-
-
def ConvertDottedKeysToNested(features):
'''Some Manifest Features are subordinate to others, such as app.background to
app. Subordinate Features can be moved inside the parent Feature under the key

Powered by Google App Engine
This is Rietveld 408576698