Docserver: Consolidate features caching and access.

chrome/common/extensions/docs/server2/template_data_source_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import os
 import sys
 import unittest
 
 from api_data_source import APIDataSource
+from features_bundle import FeaturesBundle
 from compiled_file_system import CompiledFileSystem
 from local_file_system import LocalFileSystem
 from object_store_creator import ObjectStoreCreator
 from permissions_data_source import PermissionsDataSource
 from reference_resolver import ReferenceResolver
 from template_data_source import TemplateDataSource
 from test_branch_utility import TestBranchUtility
 from test_util import DisableLogging
 from servlet import Request
 from third_party.handlebar import Handlebar
@@ skipping 13 matching lines @@
 
 class TemplateDataSourceTest(unittest.TestCase):
 
   def setUp(self):
     self._base_path = os.path.join(sys.path[0],
                                    'test_data',
                                    'template_data_source')
     self._fake_api_list_data_source_factory = _FakeFactory()
     self._fake_intro_data_source_factory = _FakeFactory()
     self._fake_samples_data_source_factory = _FakeFactory()
+    self._fake_features_bundle = FeaturesBundle(
+        LocalFileSystem.Create(), _FakeFactory(), {})

[not at google - send to devlin, 2013/10/01 16:34:34]

you would use the FakeFeatureBundle() class here.

[Ken Rockot(use gerrit already), 2013/10/01 22:18:16]

Done.

     self._permissions_data_source = PermissionsDataSource(
-      _FakeFactory(), LocalFileSystem.Create(), '', '', '')
+        self._fake_features_bundle)
 
   def _ReadLocalFile(self, filename):
     with open(os.path.join(self._base_path, filename), 'r') as f:
       return f.read()
 
   def _RenderTest(self, name, data_source):
     template_name = name + '_tmpl.html'
     template = Handlebar(self._ReadLocalFile(template_name))
     self.assertEquals(
         self._ReadLocalFile(name + '_expected.html'),
@@ skipping 82 matching lines @@
             compiled_fs_factory,
             api_data=json.loads(self._ReadLocalFile('test1.json'))))
     self._RenderTest(
         'test2',
         self._CreateTemplateDataSource(
             compiled_fs_factory,
             api_data=json.loads(self._ReadLocalFile('test2.json'))))
 
 if __name__ == '__main__':
   unittest.main()