Docserver: Consolidate features caching and access.

chrome/common/extensions/docs/server2/permissions_data_source.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from itertools import ifilter
 from operator import itemgetter
 
 import features_utility as features
 from third_party.json_schema_compiler.json_parse import Parse
 
@@ skipping 23 matching lines @@
         if dependency.startswith('permission:'):
           has_deps = True
 
     if has_deps:
       permission['partial'] = 'permissions/generic_description'
 
 class PermissionsDataSource(object):
   '''Load and format permissions features to be used by templates. Requries a
   template data source be set before use.
   '''
-  def __init__(self,
-               compiled_fs_factory,
-               file_system,
-               api_features_path,
-               permissions_features_path,
-               permissions_json_path):
-    self._api_features_path = api_features_path
-    self._permissions_features_path = permissions_features_path
-    self._permissions_json_path = permissions_json_path
-    self._file_system = file_system
-    self._cache = compiled_fs_factory.Create(
-        self._CreatePermissionsDataSource, PermissionsDataSource)
+  def __init__(self, features_bundle):
+    self._features_bundle = features_bundle
+    self._cache = None
 
   def SetTemplateDataSource(self, template_data_source_factory):
     '''Initialize a template data source to be used to render partial templates
     into descriptions for permissions. Must be called before .get
     '''
     self._template_data_source = template_data_source_factory.Create(
         None, {})
 
-  def _CreatePermissionsDataSource(self, _, content):
-    '''Combine the contents of |_permissions_json_path| and
-    |_permissions_features_path|. Filter into lists, one for extensions and
-    one for apps.
-    '''
-    api_features = Parse(self._file_system.ReadSingle(self._api_features_path))
+  def _CreateCache(self):
+    api_features = self._features_bundle.GetAPIFeatures()
+    permission_features = self._features_bundle.GetPermissionFeatures()
 
     def filter_for_platform(permissions, platform):
       return _ListifyPermissions(features.Filtered(permissions, platform))
 
-    permissions_json = Parse(self._file_system.ReadSingle(
-        self._permissions_json_path))
-    permission_features = features.MergedWith(
-        features.Parse(Parse(content)), permissions_json)
-
     _AddDependencyDescriptions(permission_features, api_features)
     # Turn partial templates into descriptions, ensure anchors are set.
     for permission in permission_features.values():
       if not 'anchor' in permission:
         permission['anchor'] = permission['name']
       if 'partial' in permission:
         permission['description'] = self._template_data_source.get(
             permission['partial'])
         del permission['partial']
 
     return {
-      'declare_apps': filter_for_platform(permission_features, 'app'),
+      'declare_apps': filter_for_platform(permission_features, 'apps'),
       'declare_extensions': filter_for_platform(
-          permission_features, 'extension')
+          permission_features, 'extensions')
     }
 
   def get(self, key):
-    return self._cache.GetFromFile(self._permissions_features_path)[key]
+    if self._cache is None:
+      self._cache = self._CreateCache()
+    return self._cache.get(key)

[not at google - send to devlin, 2013/10/01 16:34:34]

same comment as in manifest_data_source

[Ken Rockot(use gerrit already), 2013/10/01 22:18:16]

Done.