Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23867002: Move dns API to dev channel (Closed)

Created:
7 years, 3 months ago by pals
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fixed #

Patch Set 4 : Fixing the unit test failure #

Patch Set 5 : Adding missing dns.idl file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -47 lines) Patch
M chrome/browser/extensions/api/dns/dns_api.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/dns/dns_api.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 2 chunks +1 line, -1 line 0 comments Download
A + chrome/common/extensions/api/dns.idl View 4 1 chunk +1 line, -2 lines 0 comments Download
D chrome/common/extensions/api/experimental_dns.idl View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/common/extensions/api/extension_api_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/dns/api/background.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/dns/api/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
pals
+isherman : tools/ +mpcomplete : e/b/e Please review.
7 years, 3 months ago (2013-09-02 12:40:41 UTC) #1
Matt Perry
https://codereview.chromium.org/23867002/diff/3001/chrome/browser/extensions/extension_function_histogram_value.h File chrome/browser/extensions/extension_function_histogram_value.h (right): https://codereview.chromium.org/23867002/diff/3001/chrome/browser/extensions/extension_function_histogram_value.h#newcode617 chrome/browser/extensions/extension_function_histogram_value.h:617: DNS_RESOLVE, same comment as https://codereview.chromium.org/23799006/diff/1/chrome/browser/extensions/extension_function_histogram_value.h?context=50&column_width=80
7 years, 3 months ago (2013-09-03 19:29:45 UTC) #2
Matt Perry
I think we'll need to update some sample code for this, too.
7 years, 3 months ago (2013-09-03 19:32:46 UTC) #3
Ilya Sherman
histograms.xml lgtm
7 years, 3 months ago (2013-09-03 22:41:08 UTC) #4
pals
Fixed. Please review once more. https://codereview.chromium.org/23867002/diff/3001/chrome/browser/extensions/extension_function_histogram_value.h File chrome/browser/extensions/extension_function_histogram_value.h (right): https://codereview.chromium.org/23867002/diff/3001/chrome/browser/extensions/extension_function_histogram_value.h#newcode617 chrome/browser/extensions/extension_function_histogram_value.h:617: DNS_RESOLVE, On 2013/09/03 19:29:45, ...
7 years, 3 months ago (2013-09-04 13:38:53 UTC) #5
Matt Perry
lgtm
7 years, 3 months ago (2013-09-04 19:37:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23867002/11001
7 years, 3 months ago (2013-09-05 02:01:38 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82952
7 years, 3 months ago (2013-09-05 03:02:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23867002/44001
7 years, 3 months ago (2013-09-06 08:42:01 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-06 09:07:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23867002/44001
7 years, 3 months ago (2013-09-06 11:04:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23867002/82001
7 years, 3 months ago (2013-09-06 11:08:57 UTC) #12
commit-bot: I haz the power
Change committed as 221729
7 years, 3 months ago (2013-09-06 17:34:11 UTC) #13
scottmg
This causes the following spam during builds: [3967->53/4039 ~19] RULE Generating C++ code from dns.idl ...
7 years, 3 months ago (2013-09-06 19:43:47 UTC) #14
Nico
7 years, 3 months ago (2013-09-10 17:54:37 UTC) #15
Message was sent while issue was closed. 
On 2013/09/06 19:43:47, scottmg wrote:
> This causes the following spam during builds:
> 
> [3967->53/4039 ~19] RULE Generating C++ code from dns.idl IDL files
> dns must have a namespace-level comment. This will appear on the API summary
> page.
> 
> Could you fix that please?

This is still not fixed 4 days later. Please add a comment to the idl file by
tomorrow.

Powered by Google App Engine
This is Rietveld 408576698