Disable GpuMemoryBuffer backed VideoFrames in media streams

Disable GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=652068
Committed: https://crrev.com/704feb5ec21570eb28ae918cc8ff734f5da5082f
Cr-Commit-Position: refs/heads/master@{#422329}

[emircan, 2016-10-01 01:33:00]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 01:33:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emircan, 2016-10-01 01:34:11]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 01:34:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emircan, 2016-10-01 01:34:51]

Description was changed from

==========
disable switch

BUG=
==========

to

==========
Disable switch for GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=
==========

[emircan, 2016-10-01 01:34:52]

emircan@chromium.org changed reviewers:
+ dcastagna@chromium.org, tommi@chromium.org

[emircan, 2016-10-01 01:35:00]

Patchset #1 (id:1) has been deleted

[emircan, 2016-10-01 01:38:01]

PTAL. 

I added as a switch so that it conforms to the usage of 
kDisableGpuMemoryBufferVideoFrames. However, I can also change it
to a base::Feature so that it can be turned on/off via config. 
https://g3doc.corp.google.com/analysis/uma/g3doc/finch/feature-api.md?cl=head

[Daniele Castagna, 2016-10-01 01:42:45]

On 2016/10/01 at 01:38:01, emircan wrote:
> PTAL. 
> 
> I added as a switch so that it conforms to the usage of 
> kDisableGpuMemoryBufferVideoFrames. However, I can also change it
> to a base::Feature so that it can be turned on/off via config. 
> https://g3doc.corp.google.com/analysis/uma/g3doc/finch/feature-api.md?cl=head

LGTM.

Just a nit: The title could be phrased differently, something like "Add disable
switch", otherwise it seems like this CL is disabling a switch.

Up to you you/tommi if this should be a base::Feature.

[commit-bot: I haz the power, 2016-10-01 02:22:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 02:22:38]

Dry run: This issue passed the CQ dry run.

[tommi (sloooow) - chröme, 2016-10-01 09:38:47]

This adds the switch but doesn't turn the feature off by default. Given that
there are issues, should we turn it off by default and rather have an on switch?
Then when we've solved the issue we can start using the 'on' switch and
eventually remove it.

[emircan, 2016-10-01 16:33:31]

Description was changed from

==========
Disable switch for GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=
==========

to

==========
Disable switch for GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=b/31390397, I will add a CrBug if you approve of this temp fix.
==========

[emircan, 2016-10-01 17:04:47]

Description was changed from

==========
Disable switch for GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=b/31390397, I will add a CrBug if you approve of this temp fix.
==========

to

==========
Disable GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=b/31390397, I will add a CrBug if you approve of this temp fix.
==========

[emircan, 2016-10-01 17:05:38]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[emircan, 2016-10-01 17:05:40]

On 2016/10/01 09:38:47, tommi (chrömium) wrote:
> This adds the switch but doesn't turn the feature off by default. Given that
> there are issues, should we turn it off by default and rather have an on
switch?
> Then when we've solved the issue we can start using the 'on' switch and
> eventually remove it.

Ok, then I will make it a base::Feature which is disabled by default. We can use
a config file to turn it on for version or platform until fixed.

PTAL again.

[commit-bot: I haz the power, 2016-10-01 17:05:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 17:49:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 17:49:44]

Dry run: This issue passed the CQ dry run.

[tommi (sloooow) - chröme, 2016-10-01 18:46:26]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2016-10-01 18:46:27]

lgtm

that was fast :) thanks!

[tommi (sloooow) - chröme, 2016-10-01 18:46:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dcastagna@chromium.org
Link to the patchset: https://codereview.chromium.org/2386693004/#ps40001
(title: "Add base::Feature which is disabled by default.")

[commit-bot: I haz the power, 2016-10-01 18:46:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 18:51:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 18:51:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tommi (sloooow) - chröme, 2016-10-01 18:56:37]

tommi@chromium.org changed reviewers:
+ avi@chromium.org

[tommi (sloooow) - chröme, 2016-10-01 18:56:37]

+ Avi as owner for content/public/common/content_features.*

[Avi (use Gerrit), 2016-10-01 20:01:44]

lgtm

[emircan, 2016-10-01 21:04:44]

Description was changed from

==========
Disable GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=b/31390397, I will add a CrBug if you approve of this temp fix.
==========

to

==========
Disable GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=652068
==========

[emircan, 2016-10-01 21:05:02]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2016-10-01 21:05:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 21:10:08]

Description was changed from

==========
Disable GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=652068
==========

to

==========
Disable GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=652068
==========

[commit-bot: I haz the power, 2016-10-01 21:10:10]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-01 21:11:48]

Description was changed from

==========
Disable GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=652068
==========

to

==========
Disable GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=652068

Committed: https://crrev.com/704feb5ec21570eb28ae918cc8ff734f5da5082f
Cr-Commit-Position: refs/heads/master@{#422329}
==========

[commit-bot: I haz the power, 2016-10-01 21:11:50]

Patchset 2 (id:??) landed as
https://crrev.com/704feb5ec21570eb28ae918cc8ff734f5da5082f
Cr-Commit-Position: refs/heads/master@{#422329}

[emircan, 2016-10-03 18:00:41]

Description was changed from

==========
Disable GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=652068

Committed: https://crrev.com/704feb5ec21570eb28ae918cc8ff734f5da5082f
Cr-Commit-Position: refs/heads/master@{#422329}
==========

to

==========
Disable GpuMemoryBuffer backed VideoFrames in media streams

This CL adds a switch so that GpuMemoryBuffer backed VideoFrames
can be turned off specifically for WebRTC use case.

BUG=652068

Committed: https://crrev.com/704feb5ec21570eb28ae918cc8ff734f5da5082f
Cr-Commit-Position: refs/heads/master@{#422329}
==========