Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2386693003: [Remoting Android] Remove unused DesktopViewFactory (Closed)

Created:
4 years, 2 months ago by Yuwei
Modified:
4 years, 2 months ago
Reviewers:
Lambros, joedow
CC:
chromium-reviews, agrieve+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Remove unused DesktopViewFactory DesktopViewFactory is no longer used after DesktopView becomes renderer independent. This CL removes the interface. Committed: https://crrev.com/1e93c3bea28cbfda18373b01523ebcc742b0a810 Cr-Commit-Position: refs/heads/master@{#422537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M remoting/android/client_java_tmpl.gni View 1 chunk +0 lines, -1 line 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/DesktopViewFactory.java View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuwei
PTAL
4 years, 2 months ago (2016-10-01 01:06:06 UTC) #2
joedow
lgtm
4 years, 2 months ago (2016-10-01 01:39:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386693003/1
4 years, 2 months ago (2016-10-03 20:28:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 21:28:42 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:31:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e93c3bea28cbfda18373b01523ebcc742b0a810
Cr-Commit-Position: refs/heads/master@{#422537}

Powered by Google App Engine
This is Rietveld 408576698