Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: test/cctest/test-macro-assembler-mips.cc

Issue 2386673002: MIPS: Fix Sltu macro instruction. (Closed)
Patch Set: Fix nits. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/mips64/macro-assembler-mips64.cc ('k') | test/cctest/test-macro-assembler-mips64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-macro-assembler-mips.cc
diff --git a/test/cctest/test-macro-assembler-mips.cc b/test/cctest/test-macro-assembler-mips.cc
index 057c37030407439040262aa2382551ef671e7dcc..9561db691e73849584888945ff07ee327c8fdffc 100644
--- a/test/cctest/test-macro-assembler-mips.cc
+++ b/test/cctest/test-macro-assembler-mips.cc
@@ -1306,4 +1306,57 @@ TEST(Uldc1) {
}
}
+static const std::vector<uint32_t> sltu_test_values() {
+ static const uint32_t kValues[] = {
+ 0, 1, 0x7ffe, 0x7fff, 0x8000,
+ 0x8001, 0xfffe, 0xffff, 0xffff7ffe, 0xffff7fff,
+ 0xffff8000, 0xffff8001, 0xfffffffe, 0xffffffff,
+ };
+ return std::vector<uint32_t>(&kValues[0], &kValues[arraysize(kValues)]);
+}
+
+template <typename Func>
+bool run_Sltu(uint32_t rs, uint32_t rd, Func GenerateSltuInstructionFunc) {
+ typedef int32_t (*F_CVT)(uint32_t x0, uint32_t x1, int x2, int x3, int x4);
+
+ Isolate* isolate = CcTest::i_isolate();
+ HandleScope scope(isolate);
+ MacroAssembler assm(isolate, nullptr, 0,
+ v8::internal::CodeObjectRequired::kYes);
+ MacroAssembler* masm = &assm;
+
+ GenerateSltuInstructionFunc(masm, rd);
+ __ jr(ra);
+ __ nop();
+
+ CodeDesc desc;
+ assm.GetCode(&desc);
+ Handle<Code> code = isolate->factory()->NewCode(
+ desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
+
+ F_CVT f = FUNCTION_CAST<F_CVT>(code->entry());
+ int32_t res = reinterpret_cast<int32_t>(
+ CALL_GENERATED_CODE(isolate, f, rs, rd, 0, 0, 0));
+ return res == 1;
+}
+
+TEST(Sltu) {
+ CcTest::InitializeVM();
+
+ FOR_UINT32_INPUTS(i, sltu_test_values) {
+ FOR_UINT32_INPUTS(j, sltu_test_values) {
+ uint32_t rs = *i;
+ uint32_t rd = *j;
+
+ CHECK_EQ(rs < rd, run_Sltu(rs, rd,
+ [](MacroAssembler* masm, uint32_t imm) {
+ __ Sltu(v0, a0, Operand(imm));
+ }));
+ CHECK_EQ(rs < rd,
+ run_Sltu(rs, rd, [](MacroAssembler* masm,
+ uint32_t imm) { __ Sltu(v0, a0, a1); }));
+ }
+ }
+}
+
#undef __
« no previous file with comments | « src/mips64/macro-assembler-mips64.cc ('k') | test/cctest/test-macro-assembler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698