Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

Issue 2386653002: Replace base::Callback with base::OnceCallback in base::PendingTask (Closed)
Patch Set: move UnsafeConvertOnceClosureToRepeating Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/timers/alarm_timer_chromeos.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/scheduler/base/task_queue_manager.h" 5 #include "platform/scheduler/base/task_queue_manager.h"
6 6
7 #include <queue> 7 #include <queue>
8 #include <set> 8 #include <set>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 20 matching lines...) Expand all
31 31
32 void RecordImmediateTaskQueueingDuration(tracked_objects::Duration duration) { 32 void RecordImmediateTaskQueueingDuration(tracked_objects::Duration duration) {
33 UMA_HISTOGRAM_TIMES( 33 UMA_HISTOGRAM_TIMES(
34 "RendererScheduler.TaskQueueManager.ImmediateTaskQueueingDuration", 34 "RendererScheduler.TaskQueueManager.ImmediateTaskQueueingDuration",
35 base::TimeDelta::FromMilliseconds(duration.InMilliseconds())); 35 base::TimeDelta::FromMilliseconds(duration.InMilliseconds()));
36 } 36 }
37 37
38 double MonotonicTimeInSeconds(base::TimeTicks timeTicks) { 38 double MonotonicTimeInSeconds(base::TimeTicks timeTicks) {
39 return (timeTicks - base::TimeTicks()).InSecondsF(); 39 return (timeTicks - base::TimeTicks()).InSecondsF();
40 } 40 }
41
42 // Converts a OnceClosure to a RepeatingClosure. It hits CHECK failure to run
43 // the resulting RepeatingClosure more than once.
44 // TODO(tzik): This will be unneeded after the Closure-to-OnceClosure migration
45 // on TaskRunner finished. Remove it once it gets unneeded.
46 base::RepeatingClosure UnsafeConvertOnceClosureToRepeating(
47 base::OnceClosure cb) {
48 return base::BindRepeating([](base::OnceClosure cb) { std::move(cb).Run(); },
49 base::Passed(&cb));
50 }
41 } 51 }
42 52
43 TaskQueueManager::TaskQueueManager( 53 TaskQueueManager::TaskQueueManager(
44 scoped_refptr<TaskQueueManagerDelegate> delegate, 54 scoped_refptr<TaskQueueManagerDelegate> delegate,
45 const char* tracing_category, 55 const char* tracing_category,
46 const char* disabled_by_default_tracing_category, 56 const char* disabled_by_default_tracing_category,
47 const char* disabled_by_default_verbose_tracing_category) 57 const char* disabled_by_default_verbose_tracing_category)
48 : real_time_domain_(new RealTimeDomain(tracing_category)), 58 : real_time_domain_(new RealTimeDomain(tracing_category)),
49 delegate_(delegate), 59 delegate_(delegate),
50 task_was_run_on_quiescence_monitored_queue_(false), 60 task_was_run_on_quiescence_monitored_queue_(false),
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 322
313 internal::TaskQueueImpl* queue = work_queue->task_queue(); 323 internal::TaskQueueImpl* queue = work_queue->task_queue();
314 if (queue->GetQuiescenceMonitored()) 324 if (queue->GetQuiescenceMonitored())
315 task_was_run_on_quiescence_monitored_queue_ = true; 325 task_was_run_on_quiescence_monitored_queue_ = true;
316 326
317 if (!pending_task.nestable && delegate_->IsNested()) { 327 if (!pending_task.nestable && delegate_->IsNested()) {
318 // Defer non-nestable work to the main task runner. NOTE these tasks can be 328 // Defer non-nestable work to the main task runner. NOTE these tasks can be
319 // arbitrarily delayed so the additional delay should not be a problem. 329 // arbitrarily delayed so the additional delay should not be a problem.
320 // TODO(skyostil): Figure out a way to not forget which task queue the 330 // TODO(skyostil): Figure out a way to not forget which task queue the
321 // task is associated with. See http://crbug.com/522843. 331 // task is associated with. See http://crbug.com/522843.
322 delegate_->PostNonNestableTask(pending_task.posted_from, 332 // TODO(tzik): Remove base::UnsafeConvertOnceClosureToRepeating once
323 std::move(pending_task.task)); 333 // TaskRunners have migrated to OnceClosure.
334 delegate_->PostNonNestableTask(
335 pending_task.posted_from,
336 UnsafeConvertOnceClosureToRepeating(std::move(pending_task.task)));
324 return ProcessTaskResult::DEFERRED; 337 return ProcessTaskResult::DEFERRED;
325 } 338 }
326 339
327 MaybeRecordTaskDelayHistograms(pending_task, queue); 340 MaybeRecordTaskDelayHistograms(pending_task, queue);
328 341
329 TRACE_TASK_EXECUTION("TaskQueueManager::ProcessTaskFromWorkQueue", 342 TRACE_TASK_EXECUTION("TaskQueueManager::ProcessTaskFromWorkQueue",
330 pending_task); 343 pending_task);
331 if (queue->GetShouldNotifyObservers()) { 344 if (queue->GetShouldNotifyObservers()) {
332 FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver, task_observers_, 345 FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver, task_observers_,
333 WillProcessTask(pending_task)); 346 WillProcessTask(pending_task));
334 queue->NotifyWillProcessTask(pending_task); 347 queue->NotifyWillProcessTask(pending_task);
335 } 348 }
336 TRACE_EVENT1(tracing_category_, "TaskQueueManager::RunTask", "queue", 349 TRACE_EVENT1(tracing_category_, "TaskQueueManager::RunTask", "queue",
337 queue->GetName()); 350 queue->GetName());
338 // NOTE when TaskQueues get unregistered a reference ends up getting retained 351 // NOTE when TaskQueues get unregistered a reference ends up getting retained
339 // by |queues_to_delete_| which is cleared at the top of |DoWork|. This means 352 // by |queues_to_delete_| which is cleared at the top of |DoWork|. This means
340 // we are OK to use raw pointers here. 353 // we are OK to use raw pointers here.
341 internal::TaskQueueImpl* prev_executing_task_queue = 354 internal::TaskQueueImpl* prev_executing_task_queue =
342 currently_executing_task_queue_; 355 currently_executing_task_queue_;
343 currently_executing_task_queue_ = queue; 356 currently_executing_task_queue_ = queue;
344 task_annotator_.RunTask("TaskQueueManager::PostTask", pending_task); 357 task_annotator_.RunTask("TaskQueueManager::PostTask", &pending_task);
345 // Detect if the TaskQueueManager just got deleted. If this happens we must 358 // Detect if the TaskQueueManager just got deleted. If this happens we must
346 // not access any member variables after this point. 359 // not access any member variables after this point.
347 if (protect->HasOneRef()) 360 if (protect->HasOneRef())
348 return ProcessTaskResult::TASK_QUEUE_MANAGER_DELETED; 361 return ProcessTaskResult::TASK_QUEUE_MANAGER_DELETED;
349 362
350 currently_executing_task_queue_ = prev_executing_task_queue; 363 currently_executing_task_queue_ = prev_executing_task_queue;
351 364
352 if (queue->GetShouldNotifyObservers()) { 365 if (queue->GetShouldNotifyObservers()) {
353 FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver, task_observers_, 366 FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver, task_observers_,
354 DidProcessTask(pending_task)); 367 DidProcessTask(pending_task));
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 DCHECK(main_thread_checker_.CalledOnValidThread()); 478 DCHECK(main_thread_checker_.CalledOnValidThread());
466 DCHECK(!work_queue->Empty()); 479 DCHECK(!work_queue->Empty());
467 if (observer_) { 480 if (observer_) {
468 observer_->OnTriedToExecuteBlockedTask(*work_queue->task_queue(), 481 observer_->OnTriedToExecuteBlockedTask(*work_queue->task_queue(),
469 *work_queue->GetFrontTask()); 482 *work_queue->GetFrontTask());
470 } 483 }
471 } 484 }
472 485
473 } // namespace scheduler 486 } // namespace scheduler
474 } // namespace blink 487 } // namespace blink
OLDNEW
« no previous file with comments | « components/timers/alarm_timer_chromeos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698