Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: base/pending_task.cc

Issue 2386653002: Replace base::Callback with base::OnceCallback in base::PendingTask (Closed)
Patch Set: move UnsafeConvertOnceClosureToRepeating Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/pending_task.h ('k') | base/task_scheduler/task_tracker.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/pending_task.h" 5 #include "base/pending_task.h"
6 6
7 #include "base/tracked_objects.h" 7 #include "base/tracked_objects.h"
8 8
9 namespace base { 9 namespace base {
10 10
11 PendingTask::PendingTask(const tracked_objects::Location& posted_from, 11 PendingTask::PendingTask(const tracked_objects::Location& posted_from,
12 base::Closure task) 12 OnceClosure task)
13 : base::TrackingInfo(posted_from, TimeTicks()), 13 : base::TrackingInfo(posted_from, TimeTicks()),
14 task(std::move(task)), 14 task(std::move(task)),
15 posted_from(posted_from), 15 posted_from(posted_from),
16 sequence_num(0), 16 sequence_num(0),
17 nestable(true), 17 nestable(true),
18 is_high_res(false) { 18 is_high_res(false) {}
19 }
20 19
21 PendingTask::PendingTask(const tracked_objects::Location& posted_from, 20 PendingTask::PendingTask(const tracked_objects::Location& posted_from,
22 base::Closure task, 21 OnceClosure task,
23 TimeTicks delayed_run_time, 22 TimeTicks delayed_run_time,
24 bool nestable) 23 bool nestable)
25 : base::TrackingInfo(posted_from, delayed_run_time), 24 : base::TrackingInfo(posted_from, delayed_run_time),
26 task(std::move(task)), 25 task(std::move(task)),
27 posted_from(posted_from), 26 posted_from(posted_from),
28 sequence_num(0), 27 sequence_num(0),
29 nestable(nestable), 28 nestable(nestable),
30 is_high_res(false) { 29 is_high_res(false) {}
31 }
32 30
33 PendingTask::PendingTask(PendingTask&& other) = default; 31 PendingTask::PendingTask(PendingTask&& other) = default;
34 32
35 PendingTask::~PendingTask() { 33 PendingTask::~PendingTask() {
36 } 34 }
37 35
38 PendingTask& PendingTask::operator=(PendingTask&& other) = default; 36 PendingTask& PendingTask::operator=(PendingTask&& other) = default;
39 37
40 bool PendingTask::operator<(const PendingTask& other) const { 38 bool PendingTask::operator<(const PendingTask& other) const {
41 // Since the top of a priority queue is defined as the "greatest" element, we 39 // Since the top of a priority queue is defined as the "greatest" element, we
42 // need to invert the comparison here. We want the smaller time to be at the 40 // need to invert the comparison here. We want the smaller time to be at the
43 // top of the heap. 41 // top of the heap.
44 42
45 if (delayed_run_time < other.delayed_run_time) 43 if (delayed_run_time < other.delayed_run_time)
46 return false; 44 return false;
47 45
48 if (delayed_run_time > other.delayed_run_time) 46 if (delayed_run_time > other.delayed_run_time)
49 return true; 47 return true;
50 48
51 // If the times happen to match, then we use the sequence number to decide. 49 // If the times happen to match, then we use the sequence number to decide.
52 // Compare the difference to support integer roll-over. 50 // Compare the difference to support integer roll-over.
53 return (sequence_num - other.sequence_num) > 0; 51 return (sequence_num - other.sequence_num) > 0;
54 } 52 }
55 53
56 } // namespace base 54 } // namespace base
OLDNEW
« no previous file with comments | « base/pending_task.h ('k') | base/task_scheduler/task_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698