Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: base/task_scheduler/sequence.cc

Issue 2386653002: Replace base::Callback with base::OnceCallback in base::PendingTask (Closed)
Patch Set: revert most of task_scheduler changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/sequence.h" 5 #include "base/task_scheduler/sequence.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 11
12 namespace base { 12 namespace base {
13 namespace internal { 13 namespace internal {
14 14
15 Sequence::Sequence() = default; 15 Sequence::Sequence() = default;
16 16
17 bool Sequence::PushTask(std::unique_ptr<Task> task) { 17 bool Sequence::PushTask(std::unique_ptr<Task> task) {
18 DCHECK(task->sequenced_time.is_null()); 18 DCHECK(task->sequenced_time.is_null());
19 task->sequenced_time = base::TimeTicks::Now(); 19 task->sequenced_time = base::TimeTicks::Now();
20 20
21 AutoSchedulerLock auto_lock(lock_); 21 AutoSchedulerLock auto_lock(lock_);
22 ++num_tasks_per_priority_[static_cast<int>(task->traits.priority())]; 22 ++num_tasks_per_priority_[static_cast<int>(task->traits.priority())];
23 queue_.push(std::move(task)); 23 queue_.push(std::move(task));
24 24
25 // Return true if the sequence was empty before the push. 25 // Return true if the sequence was empty before the push.
26 return queue_.size() == 1; 26 return queue_.size() == 1;
27 } 27 }
28 28
29 const Task* Sequence::PeekTask() const { 29 Task* Sequence::PeekTask() const {
30 AutoSchedulerLock auto_lock(lock_); 30 AutoSchedulerLock auto_lock(lock_);
31 31
32 if (queue_.empty()) 32 if (queue_.empty())
33 return nullptr; 33 return nullptr;
34 34
35 return queue_.front().get(); 35 return queue_.front().get();
36 } 36 }
37 37
38 bool Sequence::PopTask() { 38 bool Sequence::PopTask() {
39 // Delete the popped task outside the scope of |lock_|. This prevents a double 39 // Delete the popped task outside the scope of |lock_|. This prevents a double
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 next_task_sequenced_time = queue_.front()->sequenced_time; 81 next_task_sequenced_time = queue_.front()->sequenced_time;
82 } 82 }
83 83
84 return SequenceSortKey(priority, next_task_sequenced_time); 84 return SequenceSortKey(priority, next_task_sequenced_time);
85 } 85 }
86 86
87 Sequence::~Sequence() = default; 87 Sequence::~Sequence() = default;
88 88
89 } // namespace internal 89 } // namespace internal
90 } // namespace base 90 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698