Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2386643004: content: Handle OutputSurface requests correctly. (Closed)

Created:
4 years, 2 months ago by Khushal
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

content: Handle OutputSurface requests correctly. If the compositor goes through a visible, invisible and visible sequence, we would end up queuing 2 GpuChannelHost requests. In this case, the OutputSurface request is handled when the first callback runs. So instead of asserting that there is a pending OutputSurface request when the response callback for the GpuChannel request runs, early out if the OutputSurface request was already handled. BUG=643852, 650219 Review-Url: https://codereview.chromium.org/2313683004 Cr-Commit-Position: refs/heads/master@{#416589} (cherry picked from commit 2010e7dd770842c852284502b4503c7843d05ff3) Committed: https://chromium.googlesource.com/chromium/src/+/c746ff375a2f4b47551c421cc71357a1ef8e4798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Khushal
4 years, 2 months ago (2016-10-01 19:08:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c746ff375a2f4b47551c421cc71357a1ef8e4798.

Powered by Google App Engine
This is Rietveld 408576698