Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl.h

Issue 2386633003: [Media Router] Convert MediaRouter to use GURL for presentation URLs. (Closed)
Patch Set: Respond to imcheng@ comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/presentation_service_delegate_impl.h
diff --git a/chrome/browser/media/router/presentation_service_delegate_impl.h b/chrome/browser/media/router/presentation_service_delegate_impl.h
index fb63b45a55970065cfcd440df526c45e8c14bd96..8b89af126f8b754d20ad365bc41001c80622d411 100644
--- a/chrome/browser/media/router/presentation_service_delegate_impl.h
+++ b/chrome/browser/media/router/presentation_service_delegate_impl.h
@@ -38,14 +38,12 @@ class MediaSinksObserver;
class PresentationFrameManager;
class RouteRequestResult;
-// Implementation of PresentationServiceDelegate that interfaces an
-// instance of WebContents with the Chrome Media Router. It uses the Media
-// Router to handle presentation API calls forwarded from
-// PresentationServiceImpl. In addition, it also
-// provides default presentation URL that is required for creating
-// browser-initiated sessions.
-// It is scoped to the lifetime of a WebContents, and is managed by the
-// associated WebContents.
+// Implementation of PresentationServiceDelegate that interfaces an instance of
+// WebContents with the Chrome Media Router. It uses the Media Router to handle
+// presentation API calls forwarded from PresentationServiceImpl. In addition,
+// it also provides default presentation URL that is required for creating
+// browser-initiated sessions. It is scoped to the lifetime of a WebContents,
+// and is managed by the associated WebContents.
class PresentationServiceDelegateImpl
: public content::WebContentsUserData<PresentationServiceDelegateImpl>,
public content::PresentationServiceDelegate {
@@ -93,18 +91,18 @@ class PresentationServiceDelegateImpl
void SetDefaultPresentationUrls(
int render_process_id,
int render_frame_id,
- const std::vector<std::string>& default_presentation_urls,
+ const std::vector<GURL>& default_presentation_urls,
const content::PresentationSessionStartedCallback& callback) override;
void StartSession(
int render_process_id,
int render_frame_id,
- const std::vector<std::string>& presentation_urls,
+ const std::vector<GURL>& presentation_urls,
const content::PresentationSessionStartedCallback& success_cb,
const content::PresentationSessionErrorCallback& error_cb) override;
void JoinSession(
int render_process_id,
int render_frame_id,
- const std::vector<std::string>& presentation_urls,
+ const std::vector<GURL>& presentation_urls,
const std::string& presentation_id,
const content::PresentationSessionStartedCallback& success_cb,
const content::PresentationSessionErrorCallback& error_cb) override;

Powered by Google App Engine
This is Rietveld 408576698