Index: chrome/browser/media/router/media_source_helper_unittest.cc |
diff --git a/chrome/browser/media/router/media_source_helper_unittest.cc b/chrome/browser/media/router/media_source_helper_unittest.cc |
index e0fbaedafaa59fd5e9e85f44318f237a62243b22..f73002639aff6a1c27a869999b96feb131993845 100644 |
--- a/chrome/browser/media/router/media_source_helper_unittest.cc |
+++ b/chrome/browser/media/router/media_source_helper_unittest.cc |
@@ -5,17 +5,20 @@ |
#include "chrome/browser/media/router/media_source.h" |
#include "chrome/browser/media/router/media_source_helper.h" |
#include "testing/gtest/include/gtest/gtest.h" |
+#include "url/gurl.h" |
namespace media_router { |
+constexpr char kPresentationUrl[] = "http://www.example.com/presentation.html"; |
+ |
TEST(MediaSourcesTest, IsMirroringMediaSource) { |
EXPECT_TRUE(IsTabMirroringMediaSource(MediaSourceForTab(123))); |
EXPECT_TRUE(IsDesktopMirroringMediaSource(MediaSourceForDesktop())); |
EXPECT_TRUE(IsMirroringMediaSource(MediaSourceForTab(123))); |
EXPECT_TRUE(IsMirroringMediaSource(MediaSourceForDesktop())); |
EXPECT_FALSE(IsMirroringMediaSource(MediaSourceForCastApp("CastApp"))); |
- EXPECT_FALSE( |
- IsMirroringMediaSource(MediaSourceForPresentationUrl("http://url"))); |
+ EXPECT_FALSE(IsMirroringMediaSource( |
+ MediaSourceForPresentationUrl(GURL(kPresentationUrl)))); |
} |
TEST(MediaSourcesTest, CreateMediaSource) { |
@@ -25,33 +28,25 @@ TEST(MediaSourcesTest, CreateMediaSource) { |
MediaSourceForDesktop().id()); |
EXPECT_EQ("urn:x-com.google.cast:application:DEADBEEF", |
MediaSourceForCastApp("DEADBEEF").id()); |
- EXPECT_EQ("http://example.com/", |
- MediaSourceForPresentationUrl("http://example.com/").id()); |
+ EXPECT_EQ(kPresentationUrl, |
+ MediaSourceForPresentationUrl(GURL(kPresentationUrl)).id()); |
} |
TEST(MediaSourcesTest, IsValidMediaSource) { |
EXPECT_TRUE(IsValidMediaSource(MediaSourceForTab(123))); |
EXPECT_TRUE(IsValidMediaSource(MediaSourceForDesktop())); |
EXPECT_TRUE(IsValidMediaSource(MediaSourceForCastApp("DEADBEEF"))); |
- EXPECT_TRUE( |
- IsValidMediaSource(MediaSourceForPresentationUrl("http://example.com/"))); |
EXPECT_TRUE(IsValidMediaSource( |
- MediaSourceForPresentationUrl("https://example.com/"))); |
+ MediaSourceForPresentationUrl(GURL(kPresentationUrl)))); |
+ EXPECT_TRUE(IsValidMediaSource( |
+ MediaSourceForPresentationUrl(GURL(kPresentationUrl)))); |
// Disallowed scheme |
EXPECT_FALSE(IsValidMediaSource( |
- MediaSourceForPresentationUrl("file:///some/local/path"))); |
+ MediaSourceForPresentationUrl(GURL("file:///some/local/path")))); |
// Not a URL |
- EXPECT_FALSE( |
- IsValidMediaSource(MediaSourceForPresentationUrl("totally not a url"))); |
-} |
- |
-TEST(MediaSourcesTest, PresentationUrlFromMediaSource) { |
- EXPECT_EQ("", PresentationUrlFromMediaSource(MediaSourceForTab(123))); |
- EXPECT_EQ("", PresentationUrlFromMediaSource(MediaSourceForDesktop())); |
- EXPECT_EQ("http://example.com/", |
- PresentationUrlFromMediaSource( |
- MediaSourceForPresentationUrl("http://example.com/"))); |
+ EXPECT_FALSE(IsValidMediaSource( |
+ MediaSourceForPresentationUrl(GURL("totally not a url")))); |
} |
} // namespace media_router |