Mark param as used when we force context allocation due to implement access through arguments

Mark param as used when we force context allocation due to implement access through arguments

Currently the parameter is first parsed as a reference, and then translated into a parameter. The reference stays around though, and gets resolved to the parameter. That automatically creates a use. Now that I drop all unresolved references when we abort preparsing, that also drops the unresolved reference.

Instead, mark the variable as used when its marked as forced context allocation. That's what happens in almost all other cases.

This raises the question: does it really make sense to parse parameters this ways? It seems pretty generic, but neither fast nor memory-efficient ... Did I misunderstand something?

Just land if you think the CL looks good as is.

BUG=chromium:651613
Committed: https://crrev.com/9feab2d208f0cd16cee4a11e0ba3bebb8cf71179
Cr-Commit-Position: refs/heads/master@{#39935}

[Toon Verwaest, 2016-09-30 13:36:02]

verwaest@chromium.org changed reviewers:
+ adamk@chromium.org

[Toon Verwaest, 2016-09-30 13:36:02]

ptal

[Toon Verwaest, 2016-09-30 13:39:16]

Description was changed from

==========
Mark param as used when we force context allocation due to implement access
through arguments

BUG=chromium:651613
==========

to

==========
Mark param as used when we force context allocation due to implement access
through arguments

Currently the parameter is first parsed as a reference, and then translated into
a parameter. The reference stays around though, and gets resolved to the
parameter. That automatically creates a use. Now that I drop all unresolved
references when we abort preparsing, that also drops the unresolved reference.

Instead, mark the variable as used when its marked as forced context allocation.
That's what happens in almost all other cases.

This raises the question: does it really make sense to parse parameters this
ways? It seems pretty generic, but neither fast nor memory-efficient ... Did I
misunderstand something?

Just land if you think the CL looks good as is.

BUG=chromium:651613
==========

[adamk, 2016-10-03 16:45:15]

lgtm

I'm not sure what's so wrong about this way of handling parameters, so this
change looks good as-is. Happy to discuss later if there's something more that
could be done here.

[Toon Verwaest, 2016-10-03 16:54:34]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-10-03 16:54:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 17:21:05]

Description was changed from

==========
Mark param as used when we force context allocation due to implement access
through arguments

Currently the parameter is first parsed as a reference, and then translated into
a parameter. The reference stays around though, and gets resolved to the
parameter. That automatically creates a use. Now that I drop all unresolved
references when we abort preparsing, that also drops the unresolved reference.

Instead, mark the variable as used when its marked as forced context allocation.
That's what happens in almost all other cases.

This raises the question: does it really make sense to parse parameters this
ways? It seems pretty generic, but neither fast nor memory-efficient ... Did I
misunderstand something?

Just land if you think the CL looks good as is.

BUG=chromium:651613
==========

to

==========
Mark param as used when we force context allocation due to implement access
through arguments

Currently the parameter is first parsed as a reference, and then translated into
a parameter. The reference stays around though, and gets resolved to the
parameter. That automatically creates a use. Now that I drop all unresolved
references when we abort preparsing, that also drops the unresolved reference.

Instead, mark the variable as used when its marked as forced context allocation.
That's what happens in almost all other cases.

This raises the question: does it really make sense to parse parameters this
ways? It seems pretty generic, but neither fast nor memory-efficient ... Did I
misunderstand something?

Just land if you think the CL looks good as is.

BUG=chromium:651613
==========

[commit-bot: I haz the power, 2016-10-03 17:21:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-03 17:21:32]

Description was changed from

==========
Mark param as used when we force context allocation due to implement access
through arguments

Currently the parameter is first parsed as a reference, and then translated into
a parameter. The reference stays around though, and gets resolved to the
parameter. That automatically creates a use. Now that I drop all unresolved
references when we abort preparsing, that also drops the unresolved reference.

Instead, mark the variable as used when its marked as forced context allocation.
That's what happens in almost all other cases.

This raises the question: does it really make sense to parse parameters this
ways? It seems pretty generic, but neither fast nor memory-efficient ... Did I
misunderstand something?

Just land if you think the CL looks good as is.

BUG=chromium:651613
==========

to

==========
Mark param as used when we force context allocation due to implement access
through arguments

Currently the parameter is first parsed as a reference, and then translated into
a parameter. The reference stays around though, and gets resolved to the
parameter. That automatically creates a use. Now that I drop all unresolved
references when we abort preparsing, that also drops the unresolved reference.

Instead, mark the variable as used when its marked as forced context allocation.
That's what happens in almost all other cases.

This raises the question: does it really make sense to parse parameters this
ways? It seems pretty generic, but neither fast nor memory-efficient ... Did I
misunderstand something?

Just land if you think the CL looks good as is.

BUG=chromium:651613

Committed: https://crrev.com/9feab2d208f0cd16cee4a11e0ba3bebb8cf71179
Cr-Commit-Position: refs/heads/master@{#39935}
==========

[commit-bot: I haz the power, 2016-10-03 17:21:33]

Patchset 3 (id:??) landed as
https://crrev.com/9feab2d208f0cd16cee4a11e0ba3bebb8cf71179
Cr-Commit-Position: refs/heads/master@{#39935}