content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 23866013: Make the RenderViewHostImpl update its visibility after a swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 23866013: Make the RenderViewHostImpl update its visibility after a swap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Bring symmetry to the functionality of Hide / Show across all platform-specific impls. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index ed555cc02ee3902056d4e34ae76f00031fe416cf..19412d4619532ae41a3631e2b9f0b65c5d92d3dd 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -690,6 +690,7 @@ RenderWidgetHost* RenderWidgetHostViewAura::GetRenderWidgetHost() const {

}

void RenderWidgetHostViewAura::WasShown() {

+ DCHECK(host_);

if (!host_->is_hidden())

return;

host_->WasShown();

@@ -714,6 +715,7 @@ void RenderWidgetHostViewAura::WasShown() {

}

void RenderWidgetHostViewAura::WasHidden() {

+ DCHECK(host_);

if (host_->is_hidden())

return;

host_->WasHidden();

@@ -961,10 +963,12 @@ bool RenderWidgetHostViewAura::IsSurfaceAvailableForCopy() const {

void RenderWidgetHostViewAura::Show() {

window_->Show();

+ WasShown();

}

void RenderWidgetHostViewAura::Hide() {

window_->Hide();

+ WasHidden();

}

bool RenderWidgetHostViewAura::IsShowing() {