Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 23866012: Send configuration stats together at the end of data type configuration so that (Closed)

Created:
7 years, 3 months ago by haitaol1
Modified:
7 years, 3 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org
Visibility:
Public.

Description

Send configuration stats together at the end of data type configuration so that the stats will appear in one GWS log to make it easy to analyze. BUG=236466 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224246

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -101 lines) Patch
M chrome/browser/sync/glue/data_type_manager_impl.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.cc View 1 2 3 4 2 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M sync/engine/download_unittest.cc View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M sync/internal_api/debug_info_event_listener.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/debug_info_event_listener.cc View 1 1 chunk +66 lines, -66 lines 0 comments Download
M sync/internal_api/public/data_type_debug_info_listener.h View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
haitaol1
7 years, 3 months ago (2013-09-16 22:22:14 UTC) #1
Nicolas Zea
LGTM https://codereview.chromium.org/23866012/diff/1/sync/internal_api/debug_info_event_listener.cc File sync/internal_api/debug_info_event_listener.cc (right): https://codereview.chromium.org/23866012/diff/1/sync/internal_api/debug_info_event_listener.cc#newcode233 sync/internal_api/debug_info_event_listener.cc:233: configuration_stats[i].high_priority_types_configured_before.First(); nit: fix indent (here and below)
7 years, 3 months ago (2013-09-16 22:59:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/23866012/5001
7 years, 3 months ago (2013-09-17 00:04:21 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-17 00:13:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/23866012/21001
7 years, 3 months ago (2013-09-17 00:40:09 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-17 00:47:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/23866012/18001
7 years, 3 months ago (2013-09-17 01:05:35 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=168726
7 years, 3 months ago (2013-09-17 01:54:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/23866012/51001
7 years, 3 months ago (2013-09-17 18:31:03 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) sync_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=155165
7 years, 3 months ago (2013-09-17 19:24:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/23866012/48001
7 years, 3 months ago (2013-09-19 18:14:41 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 00:15:55 UTC) #12
Message was sent while issue was closed.
Change committed as 224246

Powered by Google App Engine
This is Rietveld 408576698