Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 23866008: Allow remapping Search/Ctrl/Alt to Esc. (Closed)

Created:
7 years, 3 months ago by Yusuke Sato
Modified:
7 years, 3 months ago
Reviewers:
sky, Seigo Nonaka
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, nona+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Allow remapping Search/Ctrl/Alt to Esc. BUG=224357 TEST=new unit tests. TEST=manually checked that remapped Search works as ESC. TEST=keyboard help shows the correct label 'esc' when Search is remapped to ESC. R=nona@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/event_rewriter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/event_rewriter_unittest.cc View 3 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/ime/xkeyboard.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yusuke Sato
Please take a look.
7 years, 3 months ago (2013-09-11 14:07:41 UTC) #1
Seigo Nonaka
lgtm
7 years, 3 months ago (2013-09-12 09:27:09 UTC) #2
Yusuke Sato
On 2013/09/12 09:27:09, Seigo Nonaka wrote: > lgtm +sky Scott, could you do an owners ...
7 years, 3 months ago (2013-09-12 09:29:45 UTC) #3
sky
LGTM
7 years, 3 months ago (2013-09-12 18:00:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/23866008/1
7 years, 3 months ago (2013-09-16 16:28:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=79465
7 years, 3 months ago (2013-09-17 03:05:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/23866008/1
7 years, 3 months ago (2013-09-17 03:14:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/23866008/1
7 years, 3 months ago (2013-09-17 08:00:32 UTC) #8
Yusuke Sato
7 years, 3 months ago (2013-09-17 09:28:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r223573 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698