Make fullscreen pepper flash create a texture layer with software compositor

Make fullscreen pepper flash create a texture layer with software compositor

This switches it away from using the legacy 2D path and gets rid of a couple of copies.

BUG=269214, 275200
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222236

[piman, 2013-09-05 00:19:43]

Looks promising!

https://codereview.chromium.org/23866006/diff/17001/content/renderer/pepper/p...
File content/renderer/pepper/pepper_graphics_2d_host.cc (right):

https://codereview.chromium.org/23866006/diff/17001/content/renderer/pepper/p...
content/renderer/pepper/pepper_graphics_2d_host.cc:564: return false;
one detail, as we switch to fullscreen and back, the layer will be recreated,
after which we need to return true once, to give the mailbox again.

https://codereview.chromium.org/23866006/diff/17001/content/renderer/pepper/p...
content/renderer/pepper/pepper_graphics_2d_host.cc:573: memcpy(memory->memory(),
src, buffer_size);
image_data_->Unmap();

https://codereview.chromium.org/23866006/diff/17001/content/renderer/pepper/p...
File content/renderer/pepper/pepper_plugin_instance_impl.cc (right):

https://codereview.chromium.org/23866006/diff/17001/content/renderer/pepper/p...
content/renderer/pepper/pepper_plugin_instance_impl.cc:1814:
!!fullscreen_container_ && CommandLine::ForCurrentProcess()->HasSwitch(
Should we do this in the !fullscreen case too? With paint and draw culling, it
might save some painting of the pixels underneath I think. But I may be missing
part of the tradeoff.

https://codereview.chromium.org/23866006/diff/17001/content/renderer/pepper/p...
File content/renderer/pepper/pepper_plugin_instance_impl.h (right):

https://codereview.chromium.org/23866006/diff/17001/content/renderer/pepper/p...
content/renderer/pepper/pepper_plugin_instance_impl.h:667:
scoped_refptr<cc::TextureLayer> software_texture_layer_;
Could we combine the 2 layers? We only have one of them at a time. I don't think
there's a strong reason why we can't have texture_layer_ go through the
PrepareTextureMailbox path, if that's the holdout.

[jbauman, 2013-09-07 00:29:52]

PTAL. Modified it to always use a layer even for non-fullscreen.

[piman, 2013-09-09 20:42:53]

https://codereview.chromium.org/23866006/diff/37001/content/renderer/pepper/p...
File content/renderer/pepper/pepper_plugin_instance_impl.cc (right):

https://codereview.chromium.org/23866006/diff/37001/content/renderer/pepper/p...
content/renderer/pepper/pepper_plugin_instance_impl.cc:634:
texture_layer_->SetNeedsDisplay();
could we do SetNeedsDisplayRect when !rect.IsEmpty() ?

https://codereview.chromium.org/23866006/diff/37001/content/renderer/pepper/p...
content/renderer/pepper/pepper_plugin_instance_impl.cc:1830: bool opaque;
nit: = false

[jbauman, 2013-09-09 22:57:14]

PTAL

On 2013/09/09 20:42:53, piman wrote:
>
https://codereview.chromium.org/23866006/diff/37001/content/renderer/pepper/p...
> File content/renderer/pepper/pepper_plugin_instance_impl.cc (right):
> 
>
https://codereview.chromium.org/23866006/diff/37001/content/renderer/pepper/p...
> content/renderer/pepper/pepper_plugin_instance_impl.cc:634:
> texture_layer_->SetNeedsDisplay();
> could we do SetNeedsDisplayRect when !rect.IsEmpty() ?

Ok, I guess we can.
> 
>
https://codereview.chromium.org/23866006/diff/37001/content/renderer/pepper/p...
> content/renderer/pepper/pepper_plugin_instance_impl.cc:1830: bool opaque;
> nit: = false

Sure.

[piman, 2013-09-09 23:35:47]

LGTM, thanks!

[commit-bot: I haz the power, 2013-09-09 23:51:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/23866006/45001

[commit-bot: I haz the power, 2013-09-10 09:12:07]

Change committed as 222236