Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2386563003: Ensure typing echo pref is saved. (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure typing echo pref is saved. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=639068 Committed: https://crrev.com/bae4db478fbe99b0dadf104beb9ba9f161710894 Cr-Commit-Position: refs/heads/master@{#422610}

Patch Set 1 #

Patch Set 2 : m #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
David Tseng
4 years, 2 months ago (2016-09-30 16:38:32 UTC) #4
dmazzoni
lgtm
4 years, 2 months ago (2016-10-03 18:30:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386563003/20001
4 years, 2 months ago (2016-10-03 22:34:03 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:06:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bae4db478fbe99b0dadf104beb9ba9f161710894
Cr-Commit-Position: refs/heads/master@{#422610}

Powered by Google App Engine
This is Rietveld 408576698