Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2386553002: Hit test floats in visual painting order (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hit test floats in visual painting order BlockFlowPainter paints inlines and then the floats. Hit testing should work in reverse: hit test floats, then inlines. This patch fixes a bug where overlapping floats were hit test in the wrong order. This patch is partially based on http://wkrev.com/192854 by Jiewen Tan. Committed: https://crrev.com/8aa3f89d3b07e7052edc5adfc849eb517f20ed6f Cr-Commit-Position: refs/heads/master@{#422146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/hittesting/hittest-overlapping-floats.html View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pdr.
4 years, 2 months ago (2016-09-30 16:59:02 UTC) #7
chrishtr
lgtm
4 years, 2 months ago (2016-09-30 17:30:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386553002/1
4 years, 2 months ago (2016-09-30 17:31:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 17:37:48 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 17:40:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8aa3f89d3b07e7052edc5adfc849eb517f20ed6f
Cr-Commit-Position: refs/heads/master@{#422146}

Powered by Google App Engine
This is Rietveld 408576698