Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2386533002: MD History: update iron-list and dependencies for better scroll performance (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: update iron-list and dependencies for better scroll performance R=tsergeant@chromium.org BUG=647028 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/38d6995aaeade8b5cc6df9d1c7d3fb9cf6be176e Cr-Commit-Position: refs/heads/master@{#422653}

Patch Set 1 #

Patch Set 2 : test "fixes" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -152 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/test/data/webui/md_history/md_history_browsertest.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/passwords_and_forms_browsertest.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/settings_passwords_section_browsertest.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/bower.json View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js View 14 chunks +109 lines, -120 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-scroll-target-behavior/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-scroll-target-behavior/iron-scroll-target-behavior-extracted.js View 3 chunks +31 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 4 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Dan Beam
4 years, 2 months ago (2016-09-30 03:19:37 UTC) #2
tsergeant
lgtm I wasn't able to reproduce the behavior I mentioned on chat. CL description nit: ...
4 years, 2 months ago (2016-09-30 03:40:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386533002/20001
4 years, 2 months ago (2016-10-04 01:11:19 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 01:16:54 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 01:19:01 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38d6995aaeade8b5cc6df9d1c7d3fb9cf6be176e
Cr-Commit-Position: refs/heads/master@{#422653}

Powered by Google App Engine
This is Rietveld 408576698