Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2386523002: Enable per thread heap on ServiceWorker (Closed)

Created:
4 years, 2 months ago by keishi
Modified:
4 years, 2 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable per thread heap on ServiceWorker blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc BUG=591606 Committed: https://crrev.com/5adb2db4a75dbaabace06728494946dd15630ebc Cr-Commit-Position: refs/heads/master@{#422056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
keishi
PTAL
4 years, 2 months ago (2016-09-30 05:31:30 UTC) #6
haraken
LGTM
4 years, 2 months ago (2016-09-30 05:41:06 UTC) #7
nhiroki
lgtm
4 years, 2 months ago (2016-09-30 05:42:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386523002/1
4 years, 2 months ago (2016-09-30 07:39:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 07:44:09 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5adb2db4a75dbaabace06728494946dd15630ebc Cr-Commit-Position: refs/heads/master@{#422056}
4 years, 2 months ago (2016-09-30 07:47:19 UTC) #13
keishi
4 years, 2 months ago (2016-10-05 04:32:19 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2394763002/ by keishi@chromium.org.

The reason for reverting is: Caused crashes
crbug.com/652058
crbug.com/651702
crbug.com/652001
crbug.com/652264
crbug.com/652183
crbug.com/652556.

Powered by Google App Engine
This is Rietveld 408576698