Fix type errors in math.min() and math.max().

Fix type errors in math.min() and math.max().

Really, this works around them, but the workaround is all round better
code.

Remove the Dart implementations of min() and max() and just forward to
the JS ones. In DDC, all numbers are double, so the type checks to
handle them specifically aren't meaningful. Also, we don't need the
other special case checks in there to help dart2js optimize them.

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/20e402c43dfbcad502f794eecab81f311c421fb7

[Bob Nystrom, 2016-09-30 19:33:32]

rnystrom@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-09-30 19:36:33]

lgtm!

https://codereview.chromium.org/2386493003/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/patch/math_patch.dart (right):

https://codereview.chromium.org/2386493003/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/patch/math_patch.dart:12: => JS('num',
r'Math.min(#, #)', checkNum(a), checkNum(b)) as num/*=T*/;
Do we actually need the checkNum?  Would a null check be sufficient?

[Bob Nystrom, 2016-09-30 19:43:14]

https://codereview.chromium.org/2386493003/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/patch/math_patch.dart (right):

https://codereview.chromium.org/2386493003/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/patch/math_patch.dart:12: => JS('num',
r'Math.min(#, #)', checkNum(a), checkNum(b)) as num/*=T*/;
On 2016/09/30 19:36:33, vsm wrote:
> Do we actually need the checkNum?  Would a null check be sufficient?

Good question. I was just following the nearby code (sqrt() et al.) that also do
checkNum(). Should I change it? What about the others?

[vsm, 2016-09-30 19:45:56]

On 2016/09/30 19:43:14, Bob Nystrom wrote:
>
https://codereview.chromium.org/2386493003/diff/1/pkg/dev_compiler/tool/input...
> File pkg/dev_compiler/tool/input_sdk/patch/math_patch.dart (right):
> 
>
https://codereview.chromium.org/2386493003/diff/1/pkg/dev_compiler/tool/input...
> pkg/dev_compiler/tool/input_sdk/patch/math_patch.dart:12: => JS('num',
> r'Math.min(#, #)', checkNum(a), checkNum(b)) as num/*=T*/;
> On 2016/09/30 19:36:33, vsm wrote:
> > Do we actually need the checkNum?  Would a null check be sufficient?
> 
> Good question. I was just following the nearby code (sqrt() et al.) that also
do
> checkNum(). Should I change it? What about the others?

Heh, I should have grepped first.  This is the current definition of checkNum:

input_sdk/private/ddc_runtime/runtime.dart:// _js_helper.checkNum =
operations.notNull;

So, ignore my comment.  :-)

[Bob Nystrom, 2016-09-30 20:18:11]

Description was changed from

==========
Fix type errors in math.min() and math.max().

Really, this works around them, but the workaround is all round better
code.

Remove the Dart implementations of min() and max() and just forward to
the JS ones. In DDC, all numbers are double, so the type checks to
handle them specifically aren't meaningful. Also, we don't need the
other special case checks in there to help dart2js optimize them.
==========

to

==========
Fix type errors in math.min() and math.max().

Really, this works around them, but the workaround is all round better
code.

Remove the Dart implementations of min() and max() and just forward to
the JS ones. In DDC, all numbers are double, so the type checks to
handle them specifically aren't meaningful. Also, we don't need the
other special case checks in there to help dart2js optimize them.

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/20e402c43dfbcad502f794eecab8...
==========

[Bob Nystrom, 2016-09-30 20:18:12]

Committed patchset #1 (id:1) manually as
20e402c43dfbcad502f794eecab81f311c421fb7 (presubmit successful).