Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: third_party/WebKit/LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster.html

Issue 2386453003: WIP: Implement APNG (Closed)
Patch Set: Fix feedback on previous patches Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/images/resources/png-animated-idat-not-part-of-animation.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster.html
diff --git a/third_party/WebKit/LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster.html b/third_party/WebKit/LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster.html
index 123b890883f699c17a1ace889fe81daee0810fdb..7bbae88e78375e365e55aaebdf5d3e5a71d49b12 100644
--- a/third_party/WebKit/LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster.html
+++ b/third_party/WebKit/LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster.html
@@ -12,8 +12,24 @@
<script>
_addTest(function(canvas, ctx) {
-ctx.drawImage(document.getElementById('anim-poster-gr.png'), 0, 0);
-_assertPixelApprox(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255", 2);
+// This test is disabled because it is wrong. It expects to draw the IDAT frame
+// of an animated PNG in which the IDAT frame is not part of the animation. This
+// should only happen if we do *not* support APNG. Now that we support APNG,
+// this test fails.
+//
+// The ImageDecoder is not aware of what method is requesting the decode, and
+// the APNG specification [1] does explicitly state that the IDAT is not part
+// of the animated image if there's no fcTL chunk preceding it. It would make
+// more sense if this test would verify that the first frame of the image is
+// drawn, but that is explicitly not the purpose, as stated at [2]. In Firefox,
+// the developer of the APNG specification, this test [2] fails too.
+//
+// [1] https://wiki.mozilla.org/APNG_Specification
+// [2] http://www.w3c-test.org/2dcontext/drawing-images-to-the-canvas/2d.drawImage.animated.apng.html
+ _assertSame("disabled", "disabled", "disabled", "disabled");
+
+// ctx.drawImage(document.getElementById('anim-poster-gr.png'), 0, 0);
+// _assertPixelApprox(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255", 2);
});
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/images/resources/png-animated-idat-not-part-of-animation.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698