Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp

Issue 2386403002: Pass DOMWinow to PerformanceLongTaskTiming for attribution (Closed)
Patch Set: sync and rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
index deddc6c303c6b1b4fb936f4e0fd8d9a86bf52bc0..e9bd66435ee7f8d587d6e6ab3f2335dcc778dba3 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
@@ -87,7 +87,7 @@ TEST_F(PerformanceBaseTest, AddLongTaskTiming) {
initialize(scope.getScriptState());
// Add a long task entry, but no observer registered.
- m_base->addLongTaskTiming(1234, 5678, "www.foo.com/bar");
+ m_base->addLongTaskTiming(1234, 5678, "www.foo.com/bar", nullptr);
EXPECT_EQ(0, m_base->numLongTaskTimingEntries()); // has no effect
// Make an observer for longtask
@@ -99,7 +99,7 @@ TEST_F(PerformanceBaseTest, AddLongTaskTiming) {
m_observer->observe(options, exceptionState);
// Add a long task entry
- m_base->addLongTaskTiming(1234, 5678, "www.foo.com/bar");
+ m_base->addLongTaskTiming(1234, 5678, "www.foo.com/bar", nullptr);
EXPECT_EQ(1, m_base->numLongTaskTimingEntries()); // added an entry
}

Powered by Google App Engine
This is Rietveld 408576698