Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2386393002: [Sync] Clean up UIModelWorkerTest. (Closed)

Created:
4 years, 2 months ago by maxbogue
Modified:
4 years, 2 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Clean up UIModelWorkerTest. It contained a lot of unnecessary things. BUG= Committed: https://crrev.com/2ec8e1aa34e6c562695aaf6953314ee33b2ab3b5 Cr-Commit-Position: refs/heads/master@{#422948}

Patch Set 1 #

Patch Set 2 : Remove extra includes. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -69 lines) Patch
M components/sync/driver/glue/ui_model_worker_unittest.cc View 1 2 2 chunks +30 lines, -69 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
maxbogue
Pavel, PTAL!
4 years, 2 months ago (2016-10-04 02:47:44 UTC) #8
pavely
lgtm
4 years, 2 months ago (2016-10-04 18:31:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386393002/20001
4 years, 2 months ago (2016-10-04 18:44:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/273320)
4 years, 2 months ago (2016-10-04 18:53:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386393002/40001
4 years, 2 months ago (2016-10-04 20:51:13 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-04 21:51:34 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 21:54:44 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ec8e1aa34e6c562695aaf6953314ee33b2ab3b5
Cr-Commit-Position: refs/heads/master@{#422948}

Powered by Google App Engine
This is Rietveld 408576698